Commit 4960eebb authored by ager@chromium.org's avatar ager@chromium.org

Oilpan: Disable the GC_PLUGIN_IGNORE annotation when compiling with asan.

For some reason having this annotation leads to linker errors on the
oilpan asan build.

obj/third_party/WebKit/Source/modules/libmodules.a(obj/third_party/WebKit/Source/modules/webdatabase/modules.DatabaseSync.o):../../third_party/WebKit/Source/modules/webdatabase/DatabaseSync.cpp:function __unnamed_1: error: undefined reference to '.str'

obj/third_party/WebKit/Source/modules/libmodules.a(obj/third_party/WebKit/Source/modules/webdatabase/modules.DatabaseSync.o):../../third_party/WebKit/Source/modules/webdatabase/DatabaseSync.cpp:function __unnamed_1: error: undefined reference to '.str1'

Kostya, do you have any ideas why this might break the asan build?

R=kcc@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/204673002

git-svn-id: svn://svn.chromium.org/blink/trunk@169564 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent edb52b20
...@@ -1046,10 +1046,10 @@ T* adoptRefCountedGarbageCollected(T* ptr) ...@@ -1046,10 +1046,10 @@ T* adoptRefCountedGarbageCollected(T* ptr)
// ignore a particular class or field when checking for proper usage. When using // ignore a particular class or field when checking for proper usage. When using
// GC_PLUGIN_IGNORE a bug-number should be provided as an argument where the // GC_PLUGIN_IGNORE a bug-number should be provided as an argument where the
// bug describes what needs to happen to remove the GC_PLUGIN_IGNORE again. // bug describes what needs to happen to remove the GC_PLUGIN_IGNORE again.
#if COMPILER(CLANG) #if COMPILER(CLANG) && !defined(ADDRESS_SANITIZER)
#define STACK_ALLOCATED() \ #define STACK_ALLOCATED() \
private: \ private: \
__attribute__((annotate("blink_stack_allocated"))) \ __attribute__((annotate("blink_stack_allocated"))) \
void* operator new(size_t) = delete; void* operator new(size_t) = delete;
#define GC_PLUGIN_IGNORE(bug) \ #define GC_PLUGIN_IGNORE(bug) \
__attribute__((annotate("blink_gc_plugin_ignore"))) __attribute__((annotate("blink_gc_plugin_ignore")))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment