Commit 4976b07c authored by danakj's avatar danakj Committed by Commit Bot

Fix http/tests/security/mixedContent/insecure-iframe-in-main-frame.html

When dumping the navigation history, dump windows opened by the main
test window also.

R=avi@chromium.org

Bug: 771003, 1069111
Change-Id: I6fad87666ee9542c51648dc7bf6cba493a105bab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218482Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772720}
parent 753f075f
...@@ -701,23 +701,17 @@ void WebTestControlHost::InitiateCaptureDump(bool capture_navigation_history, ...@@ -701,23 +701,17 @@ void WebTestControlHost::InitiateCaptureDump(bool capture_navigation_history,
return; return;
if (capture_navigation_history) { if (capture_navigation_history) {
RenderFrameHost* main_rfh = main_window_->web_contents()->GetMainFrame();
for (auto* window : Shell::windows()) { for (auto* window : Shell::windows()) {
WebContents* web_contents = window->web_contents(); WebContents* web_contents = window->web_contents();
// Only capture the history from windows in the same process_host as the // Only dump the main test window, and windows that it opened. This avoids
// main window. During web tests, we only use two processes when a // devtools windows specifically.
// devtools window is open. if (window == main_window_ || web_contents->HasOpener()) {
// TODO(https://crbug.com/771003): Dump history for all WebContentses, not navigation_history_dump_ +=
// just ones that happen to be in the same process_host as the main test "\n============== Back Forward List ==============\n";
// window's main frame. navigation_history_dump_ += DumpHistoryForWebContents(web_contents);
if (main_rfh->GetProcess() != web_contents->GetMainFrame()->GetProcess()) navigation_history_dump_ +=
continue; "===============================================\n";
}
navigation_history_dump_ +=
"\n============== Back Forward List ==============\n";
navigation_history_dump_ += DumpHistoryForWebContents(web_contents);
navigation_history_dump_ +=
"===============================================\n";
} }
} }
......
...@@ -94,8 +94,6 @@ crbug.com/901056 virtual/synchronous_html_parser/http/tests/preload/meta-viewpor ...@@ -94,8 +94,6 @@ crbug.com/901056 virtual/synchronous_html_parser/http/tests/preload/meta-viewpor
# Tests temporarily disabled with Site Isolation - test issues or test harness # Tests temporarily disabled with Site Isolation - test issues or test harness
# issues (e.g. missing OOPIF support in the test harness). # issues (e.g. missing OOPIF support in the test harness).
# TODO(lukasza, alexmos): Burn down this list. # TODO(lukasza, alexmos): Burn down this list.
crbug.com/771003 http/tests/security/mixedContent/insecure-iframe-in-main-frame.html [ Failure ]
crbug.com/1050826 external/wpt/mixed-content/gen/top.http-rp/opt-in/object-tag.https.html [ Timeout ] crbug.com/1050826 external/wpt/mixed-content/gen/top.http-rp/opt-in/object-tag.https.html [ Timeout ]
# Tests temporarily disabled with Site Isolation - uninvestigated bugs: # Tests temporarily disabled with Site Isolation - uninvestigated bugs:
......
...@@ -483,7 +483,6 @@ ...@@ -483,7 +483,6 @@
"http/tests/printing/cross-site-frame-scrolled.html", "http/tests/printing/cross-site-frame-scrolled.html",
"http/tests/printing/cross-site-frame.html", "http/tests/printing/cross-site-frame.html",
"http/tests/security/frameNavigation/xss-DENIED-top-navigation-without-user-gesture.html", "http/tests/security/frameNavigation/xss-DENIED-top-navigation-without-user-gesture.html",
"http/tests/security/mixedContent/insecure-iframe-in-main-frame.html",
"http/tests/security/upgrade-insecure-requests/iframe-upgrade.https.html", "http/tests/security/upgrade-insecure-requests/iframe-upgrade.https.html",
"http/tests/text-autosizing/narrow-iframe.html", "http/tests/text-autosizing/narrow-iframe.html",
"http/tests/text-autosizing/wide-iframe.html", "http/tests/text-autosizing/wide-iframe.html",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment