Assistant: Update device locale when pref changes

This patch updates device_settings' locale when user changes the voice
interaction pref kArcVoiceInteractionValuePropAccepted.

Bug: b/110094434, b/80431063
Test: manual. Can see updated locale in the log.
Change-Id: I80c90aca6c2e7c57cd2fd96ba998f43812e685c8
Reviewed-on: https://chromium-review.googlesource.com/1112617
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569794}

chromeos/services/assistant/assistant_manager_service_impl.cc

@@ -43,9 +43,14 @@ AssistantManagerServiceImpl::AssistantManagerServiceImpl(
       action_module_(std::make_unique<action::CrosActionModule>(this)),
       display_connection_(std::make_unique<CrosDisplayConnection>(this)),
       main_thread_task_runner_(base::ThreadTaskRunnerHandle::Get()),
+      voice_interaction_observer_binding_(this),
       weak_factory_(this) {
   connector->BindInterface(ash::mojom::kServiceName,
                            &voice_interaction_controller_);
+
+  ash::mojom::VoiceInteractionObserverPtr ptr;
+  voice_interaction_observer_binding_.Bind(mojo::MakeRequest(&ptr));
+  voice_interaction_controller_->AddObserver(std::move(ptr));
 }
 
 AssistantManagerServiceImpl::~AssistantManagerServiceImpl() {}
@@ -246,6 +251,11 @@ bool AssistantManagerServiceImpl::IsSettingSupported(
           setting_id == kBluetoothDeviceSettingId);
 }
 
+void AssistantManagerServiceImpl::OnVoiceInteractionSetupCompleted(
+    bool completed) {
+  UpdateDeviceLocale(completed);
+}
+
 void AssistantManagerServiceImpl::StartAssistantInternal(
     base::OnceCallback<void()> callback,
     const std::string& access_token,

chromeos/services/assistant/assistant_manager_service_impl.h

@@ -21,6 +21,7 @@
 #include "libassistant/contrib/core/macros.h"
 #include "libassistant/shared/internal_api/assistant_manager_delegate.h"
 #include "libassistant/shared/public/conversation_state_listener.h"
+#include "mojo/public/cpp/bindings/binding.h"
 #include "mojo/public/cpp/bindings/interface_ptr_set.h"
 #include "services/device/public/mojom/battery_monitor.mojom.h"
 
@@ -46,7 +47,8 @@ class AssistantManagerServiceImpl
       public ::chromeos::assistant::action::AssistantActionObserver,
       public AssistantEventObserver,
       public assistant_client::ConversationStateListener,
-      public assistant_client::AssistantManagerDelegate {
+      public assistant_client::AssistantManagerDelegate,
+      public ash::mojom::VoiceInteractionObserver {
  public:
   AssistantManagerServiceImpl(service_manager::Connector* connector,
                               device::mojom::BatteryMonitorPtr battery_monitor);
@@ -98,6 +100,15 @@ class AssistantManagerServiceImpl
       const std::string& modify_setting_args_proto) override;
   bool IsSettingSupported(const std::string& setting_id) override;
 
+  // ash::mojom::VoiceInteractionObserver:
+  void OnVoiceInteractionStatusChanged(
+      ash::mojom::VoiceInteractionState state) override {}
+  void OnVoiceInteractionSettingsEnabled(bool enabled) override {}
+  void OnVoiceInteractionContextEnabled(bool enabled) override {}
+  void OnVoiceInteractionSetupCompleted(bool completed) override;
+  void OnAssistantFeatureAllowedChanged(
+      ash::mojom::AssistantAllowedState state) override {}
+
  private:
   void StartAssistantInternal(
       base::OnceClosure callback,
@@ -147,6 +158,8 @@ class AssistantManagerServiceImpl
   mojo::InterfacePtrSet<mojom::AssistantEventSubscriber> subscribers_;
   scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_;
   ash::mojom::VoiceInteractionControllerPtr voice_interaction_controller_;
+  mojo::Binding<ash::mojom::VoiceInteractionObserver>
+      voice_interaction_observer_binding_;
   base::WeakPtrFactory<AssistantManagerServiceImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AssistantManagerServiceImpl);