Commit 4995c4cd authored by Sadrul Habib Chowdhury's avatar Sadrul Habib Chowdhury Committed by Commit Bot

viz: Remove unused interface from OutputSurfaceClient.

The only override of OutputSurfaceClient::DidFinishLatencyInfo() in
Display is a no-op (since crrev.com/567297). So remove this.

BUG=none

Change-Id: I53031545844ace0552ca88b30b78bc4d9d12ecb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928561
Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: default avatarSaman Sami <samans@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717716}
parent 25dfa622
...@@ -20,8 +20,6 @@ class FakeOutputSurfaceClient : public viz::OutputSurfaceClient { ...@@ -20,8 +20,6 @@ class FakeOutputSurfaceClient : public viz::OutputSurfaceClient {
void DidReceiveCALayerParams( void DidReceiveCALayerParams(
const gfx::CALayerParams& ca_layer_params) override {} const gfx::CALayerParams& ca_layer_params) override {}
void DidSwapWithSize(const gfx::Size& pixel_size) override {} void DidSwapWithSize(const gfx::Size& pixel_size) override {}
void DidFinishLatencyInfo(
const std::vector<ui::LatencyInfo>& latency_info) override {}
void DidReceivePresentationFeedback( void DidReceivePresentationFeedback(
const gfx::PresentationFeedback& feedback) override {} const gfx::PresentationFeedback& feedback) override {}
......
...@@ -760,10 +760,6 @@ void Display::DidReceivePresentationFeedback( ...@@ -760,10 +760,6 @@ void Display::DidReceivePresentationFeedback(
pending_presentation_group_timings_.pop_front(); pending_presentation_group_timings_.pop_front();
} }
void Display::DidFinishLatencyInfo(
const std::vector<ui::LatencyInfo>& latency_info) {
}
void Display::SetNeedsRedrawRect(const gfx::Rect& damage_rect) { void Display::SetNeedsRedrawRect(const gfx::Rect& damage_rect) {
aggregator_->SetFullDamageForSurface(current_surface_id_); aggregator_->SetFullDamageForSurface(current_surface_id_);
if (scheduler_) { if (scheduler_) {
......
...@@ -149,8 +149,6 @@ class VIZ_SERVICE_EXPORT Display : public DisplaySchedulerClient, ...@@ -149,8 +149,6 @@ class VIZ_SERVICE_EXPORT Display : public DisplaySchedulerClient,
void DidSwapWithSize(const gfx::Size& pixel_size) override; void DidSwapWithSize(const gfx::Size& pixel_size) override;
void DidReceivePresentationFeedback( void DidReceivePresentationFeedback(
const gfx::PresentationFeedback& feedback) override; const gfx::PresentationFeedback& feedback) override;
void DidFinishLatencyInfo(
const std::vector<ui::LatencyInfo>& latency_info) override;
// LatestLocalSurfaceIdLookupDelegate implementation. // LatestLocalSurfaceIdLookupDelegate implementation.
LocalSurfaceId GetSurfaceAtAggregation( LocalSurfaceId GetSurfaceAtAggregation(
......
...@@ -49,10 +49,6 @@ class VIZ_SERVICE_EXPORT OutputSurfaceClient { ...@@ -49,10 +49,6 @@ class VIZ_SERVICE_EXPORT OutputSurfaceClient {
virtual void DidReceivePresentationFeedback( virtual void DidReceivePresentationFeedback(
const gfx::PresentationFeedback& feedback) {} const gfx::PresentationFeedback& feedback) {}
// Call after a swap occurs with all LatencyInfo aggregated up to that point.
virtual void DidFinishLatencyInfo(
const std::vector<ui::LatencyInfo>& latency_info) = 0;
protected: protected:
virtual ~OutputSurfaceClient() {} virtual ~OutputSurfaceClient() {}
}; };
......
...@@ -185,7 +185,6 @@ void GLOutputSurface::OnGpuSwapBuffersCompleted( ...@@ -185,7 +185,6 @@ void GLOutputSurface::OnGpuSwapBuffersCompleted(
UpdateLatencyInfoOnSwap(params.swap_response, &latency_info); UpdateLatencyInfoOnSwap(params.swap_response, &latency_info);
latency_tracker_.OnGpuSwapBuffersCompleted(latency_info); latency_tracker_.OnGpuSwapBuffersCompleted(latency_info);
client_->DidFinishLatencyInfo(latency_info);
if (needs_swap_size_notifications_) if (needs_swap_size_notifications_)
client_->DidSwapWithSize(pixel_size); client_->DidSwapWithSize(pixel_size);
......
...@@ -111,7 +111,6 @@ void SoftwareOutputSurface::SwapBuffersCallback(base::TimeTicks swap_time, ...@@ -111,7 +111,6 @@ void SoftwareOutputSurface::SwapBuffersCallback(base::TimeTicks swap_time,
const gfx::Size& pixel_size) { const gfx::Size& pixel_size) {
auto& latency_info = stored_latency_info_.front(); auto& latency_info = stored_latency_info_.front();
latency_tracker_.OnGpuSwapBuffersCompleted(latency_info); latency_tracker_.OnGpuSwapBuffersCompleted(latency_info);
client_->DidFinishLatencyInfo(latency_info);
std::vector<ui::LatencyInfo>().swap(latency_info); std::vector<ui::LatencyInfo>().swap(latency_info);
client_->DidReceiveSwapBuffersAck({swap_time, swap_time}); client_->DidReceiveSwapBuffersAck({swap_time, swap_time});
stored_latency_info_.pop(); stored_latency_info_.pop();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment