Commit 49b5d4f3 authored by estade@chromium.org's avatar estade@chromium.org

fix appearance of buttons in chrome://settings

non-standard buttons in chrome://settings were broken in r109201 because the specificity of the button rules got greater when :not(.custom-appearance) was added. This is a sorry and unanticipated side effect of this approach (proposed by yours truly).

BUG=none
TEST=deletable list item close buttons, subpage close buttons go back to normal look

Review URL: http://codereview.chromium.org/8510042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109759 0039d316-1c4b-4281-b951-d872f2087c98
parent 16aac2e7
......@@ -81,7 +81,8 @@ document.documentElement.setAttribute('touchui', true);
<div id="notification">
<span></span>
<div id="notificationLinks"></div>
<button class="close-button" class="custom-appearance"></button>
<button class="close-button custom-appearance" class="custom-appearance">
</button>
</div>
</div>
......
......@@ -191,9 +191,8 @@ cr.define('options.accounts', function() {
if (!this.user.owner) {
var removeButton = this.ownerDocument.createElement('button');
removeButton.classList.add('raw-button');
removeButton.classList.add('remove-user-button');
removeButton.classList.add('custom-appearance');
removeButton.className =
'raw-button remove-user-button custom-appearance';
this.appendChild(removeButton);
}
},
......
......@@ -46,8 +46,8 @@ cr.define('options', function() {
this.appendChild(this.contentElement_);
this.closeButtonElement_ = this.ownerDocument.createElement('button');
this.closeButtonElement_.classList.add('raw-button');
this.closeButtonElement_.classList.add('close-button');
this.closeButtonElement_.className =
'raw-button close-button custom-appearance';
this.closeButtonElement_.addEventListener('mousedown',
this.handleMouseDownUpOnClose_);
this.closeButtonElement_.addEventListener('mouseup',
......
......@@ -135,7 +135,7 @@
<div id="subpage-sheet-container-1"
class="subpage-sheet-container transparent" hidden>
<div id="subpage-sheet-1" class="subpage-sheet">
<button class="raw-button close-subpage"></button>
<button class="raw-button close-subpage custom-appearance"></button>
<div class="subpage-sheet-contents">
<if expr="pp_ifdef('chromeos')">
<include src="about_page.html">
......@@ -157,7 +157,7 @@
<div id="subpage-sheet-container-2"
class="subpage-sheet-container transparent" hidden>
<div id="subpage-sheet-2" class="subpage-sheet">
<button class="raw-button close-subpage"></button>
<button class="raw-button close-subpage custom-appearance"></button>
<div class="subpage-sheet-contents">
<if expr="pp_ifdef('chromeos')">
<include src="chromeos/language_chewing_options.html">
......
......@@ -122,7 +122,7 @@ cr.define('options.search_engines', function() {
// is implemented. When this is removed, remove the extra div above.
if (engine['canBeDefault']) {
var makeDefaultButtonEl = this.ownerDocument.createElement('button');
makeDefaultButtonEl.className = "raw-button";
makeDefaultButtonEl.className = 'raw-button custom-appearance';
makeDefaultButtonEl.textContent =
templateData.makeDefaultSearchEngineButton;
makeDefaultButtonEl.onclick = function(e) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment