Commit 49c8f400 authored by Ramin Halavati's avatar Ramin Halavati Committed by Commit Bot

Update incognito/OTR comments in profile classes.

Some minor updated regarding incognito and off the record in profile
classes.

Bug: 968028
Change-Id: I2e842f43a89f113f615d7c691a26a1326a7ccab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649321Reviewed-by: default avatarMihai Sardarescu <msarda@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667171}
parent 5c43919c
...@@ -391,8 +391,8 @@ void ProfileIOData::InitializeOnUIThread(Profile* profile) { ...@@ -391,8 +391,8 @@ void ProfileIOData::InitializeOnUIThread(Profile* profile) {
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner = scoped_refptr<base::SingleThreadTaskRunner> io_task_runner =
base::CreateSingleThreadTaskRunnerWithTraits({BrowserThread::IO}); base::CreateSingleThreadTaskRunnerWithTraits({BrowserThread::IO});
// These members are used only for sign in, which is not enabled // These members are used only for sign in, which is not enabled in incognito
// in incognito mode. So no need to initialize them. // and guest modes. So no need to initialize them.
if (!IsOffTheRecord()) { if (!IsOffTheRecord()) {
google_services_user_account_id_.Init(prefs::kGoogleServicesUserAccountId, google_services_user_account_id_.Init(prefs::kGoogleServicesUserAccountId,
pref_service); pref_service);
......
...@@ -348,7 +348,7 @@ class ProfileManager : public content::NotificationObserver, ...@@ -348,7 +348,7 @@ class ProfileManager : public content::NotificationObserver,
// (desktop) Guest User profile and (desktop) System Profile. // (desktop) Guest User profile and (desktop) System Profile.
void SetNonPersonalProfilePrefs(Profile* profile); void SetNonPersonalProfilePrefs(Profile* profile);
// For ChromeOS, determines if profile should be otr. // Determines if profile should be OTR.
bool ShouldGoOffTheRecord(Profile* profile); bool ShouldGoOffTheRecord(Profile* profile);
void RunCallbacks(const std::vector<CreateCallback>& callbacks, void RunCallbacks(const std::vector<CreateCallback>& callbacks,
......
...@@ -66,9 +66,10 @@ void UpdateProfileName(Profile* profile, ...@@ -66,9 +66,10 @@ void UpdateProfileName(Profile* profile,
#endif // !defined(OS_CHROMEOS) #endif // !defined(OS_CHROMEOS)
// Returns whether the |browser|'s profile is a non-incognito or guest profile. // Returns whether the |browser|'s profile is not incognito (a regular profile
// The distinction is needed because guest profiles are implemented as // or a guest session).
// incognito profiles. // The distinction is needed because guest profiles and incognito profiles are
// implemented as off-the-record profiles.
bool IsRegularOrGuestSession(Browser* browser); bool IsRegularOrGuestSession(Browser* browser);
// Returns true if sign in is required to browse as this profile. Call with // Returns true if sign in is required to browse as this profile. Call with
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment