Commit 49dacbd1 authored by James Cook's avatar James Cook Committed by Commit Bot

chromeos: Delete OverviewSessionTest.DontRestoreFocusToUnparentedWindow

The test was only relevant to SingleProcessMash, which was cancelled.
The teardown flow it tests shouldn't happen any more.

Bug: 922293
Test: ash_unittests
Change-Id: Iabd150315ae4f0618462924a379108832530bd69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752540
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: default avatarSammie Quon <sammiequon@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686570}
parent ceb77086
...@@ -1086,29 +1086,6 @@ TEST_F(OverviewSessionTest, LastWindowDestroyed) { ...@@ -1086,29 +1086,6 @@ TEST_F(OverviewSessionTest, LastWindowDestroyed) {
EXPECT_FALSE(InOverviewSession()); EXPECT_FALSE(InOverviewSession());
} }
// Regression test for crash when closing the last overview mode window under
// SingleProcessMash. https://crbug.com/922293.
TEST_F(OverviewSessionTest, DontRestoreFocusToUnparentedWindow) {
const gfx::Rect bounds(400, 400);
std::unique_ptr<aura::Window> parent = CreateTestWindow(bounds);
std::unique_ptr<aura::Window> child = CreateChildWindow(parent.get(), bounds);
// Enter overview with a focused child window. This simulates an app window
// web contents RenderWidgetHostViewAura.
child->Focus();
ToggleOverview();
// Simulate the asynchronous window teardown for used by client widgets.
// Hierarchy changes are processed first, so the child is removed from its
// parent, then the windows are destroyed.
parent->RemoveChild(child.get());
parent.reset();
child.reset();
// Overview mode exits without crashing.
EXPECT_FALSE(InOverviewSession());
}
// Tests that entering overview mode restores a window to its original // Tests that entering overview mode restores a window to its original
// target location. // target location.
TEST_F(OverviewSessionTest, QuickReentryRestoresInitialTransform) { TEST_F(OverviewSessionTest, QuickReentryRestoresInitialTransform) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment