Use IdentityManagerFactory::GetFor*() as static methods

Followup to review comment on
https://chromium-review.googlesource.com/c/chromium/src/+/928654.

TBR=jam@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib2c5b3a86929491272399df515638e813b65db25
Reviewed-on: https://chromium-review.googlesource.com/939462
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539834}

chrome/browser/ui/autofill/chrome_autofill_client.cc

@@ -129,8 +129,7 @@ syncer::SyncService* ChromeAutofillClient::GetSyncService() {
 identity::IdentityManager* ChromeAutofillClient::GetIdentityManager() {
   Profile* profile =
       Profile::FromBrowserContext(web_contents()->GetBrowserContext());
-  return IdentityManagerFactory::GetInstance()->GetForProfile(
-      profile->GetOriginalProfile());
+  return IdentityManagerFactory::GetForProfile(profile->GetOriginalProfile());
 }
 
 ukm::UkmRecorder* ChromeAutofillClient::GetUkmRecorder() {

chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc

@@ -60,7 +60,7 @@ CvcUnmaskViewController::CvcUnmaskViewController(
               ->GetRequestContext(),
           Profile::FromBrowserContext(web_contents_->GetBrowserContext())
               ->GetPrefs(),
-          IdentityManagerFactory::GetInstance()->GetForProfile(
+          IdentityManagerFactory::GetForProfile(
               Profile::FromBrowserContext(web_contents_->GetBrowserContext())
                   ->GetOriginalProfile()),
           /*unmask_delegate=*/this,

ios/chrome/browser/autofill/personal_data_manager_factory.cc

@@ -49,12 +49,12 @@ PersonalDataManagerFactory::BuildServiceInstanceFor(
       ios::ChromeBrowserState::FromBrowserState(context);
   std::unique_ptr<PersonalDataManager> service(
       new PersonalDataManager(GetApplicationContext()->GetApplicationLocale()));
-  service->Init(ios::WebDataServiceFactory::GetAutofillWebDataForBrowserState(
-                    chrome_browser_state, ServiceAccessType::EXPLICIT_ACCESS),
-                chrome_browser_state->GetPrefs(),
-                IdentityManagerFactory::GetInstance()->GetForBrowserState(
-                    chrome_browser_state),
-                chrome_browser_state->IsOffTheRecord());
+  service->Init(
+      ios::WebDataServiceFactory::GetAutofillWebDataForBrowserState(
+          chrome_browser_state, ServiceAccessType::EXPLICIT_ACCESS),
+      chrome_browser_state->GetPrefs(),
+      IdentityManagerFactory::GetForBrowserState(chrome_browser_state),
+      chrome_browser_state->IsOffTheRecord());
   return service;
 }
 

ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm

@@ -46,9 +46,8 @@ ChromeAutofillClientIOS::ChromeAutofillClientIOS(
           browser_state->GetOriginalChromeBrowserState())),
       web_state_(web_state),
       bridge_(bridge),
-      identity_manager_(
-          IdentityManagerFactory::GetInstance()->GetForBrowserState(
-              browser_state->GetOriginalChromeBrowserState())),
+      identity_manager_(IdentityManagerFactory::GetForBrowserState(
+          browser_state->GetOriginalChromeBrowserState())),
       autofill_web_data_service_(
           ios::WebDataServiceFactory::GetAutofillWebDataForBrowserState(
               browser_state,

ios/web_view/internal/autofill/cwv_autofill_controller.mm

@@ -83,8 +83,8 @@
         ios_web_view::WebViewPersonalDataManagerFactory::GetForBrowserState(
             browserState->GetRecordingBrowserState()),
         _webState, self,
-        ios_web_view::WebViewIdentityManagerFactory::GetInstance()
-            ->GetForBrowserState(browserState),
+        ios_web_view::WebViewIdentityManagerFactory::GetForBrowserState(
+            browserState),
         ios_web_view::WebViewWebDataServiceWrapperFactory::
             GetAutofillWebDataForBrowserState(
                 browserState, ServiceAccessType::EXPLICIT_ACCESS)));

ios/web_view/internal/autofill/web_view_personal_data_manager_factory.cc

@@ -55,8 +55,7 @@ WebViewPersonalDataManagerFactory::BuildServiceInstanceFor(
       WebViewWebDataServiceWrapperFactory::GetAutofillWebDataForBrowserState(
           browser_state, ServiceAccessType::EXPLICIT_ACCESS),
       browser_state->GetPrefs(),
-      WebViewIdentityManagerFactory::GetInstance()->GetForBrowserState(
-          browser_state),
+      WebViewIdentityManagerFactory::GetForBrowserState(browser_state),
       browser_state->IsOffTheRecord());
   return service;
 }