Commit 4a3bc42c authored by Maggie Chen's avatar Maggie Chen Committed by Commit Bot

Revert "Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase"

This reverts commit 23971187.

Reason for revert: <Waiting for the other V8 change rolling up into Chrome build. Revert this CL for now.>

Original change's description:
> Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase
> 
> Increase max_old_space_size to 4 GB based on availability of physical memory.
> The purpose of this finch is to support web apps that require more heap space
> for their data sets
> 
> Bug:958974
> 
> Change-Id: I7f6bb9e69a306331242434cfc03acd68ad32333d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592792
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Commit-Queue: Maggie Chen <magchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656851}

TBR=sky@chromium.org,zmo@chromium.org,bcwhite@chromium.org,magchen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 958974
Change-Id: I304ebbd702a000ee5f4a6d5956d3c61075144711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598484Reviewed-by: default avatarMaggie Chen <magchen@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657461}
parent 712c3cf3
...@@ -18,8 +18,4 @@ const base::Feature kV8FlushBytecode{"V8FlushBytecode", ...@@ -18,8 +18,4 @@ const base::Feature kV8FlushBytecode{"V8FlushBytecode",
const base::Feature kV8MemoryReducerForSmallHeaps{ const base::Feature kV8MemoryReducerForSmallHeaps{
"V8MemoryReducerForSmallHeaps", base::FEATURE_ENABLED_BY_DEFAULT}; "V8MemoryReducerForSmallHeaps", base::FEATURE_ENABLED_BY_DEFAULT};
// Increase V8 heap size to 4GB if the physical memory is bigger than 16 GB.
const base::Feature kV8HugeMaxOldGenerationSize{
"V8HugeMaxOldGenerationSize", base::FEATURE_DISABLED_BY_DEFAULT};
} // namespace features } // namespace features
...@@ -13,7 +13,6 @@ namespace features { ...@@ -13,7 +13,6 @@ namespace features {
GIN_EXPORT extern const base::Feature kV8OptimizeJavascript; GIN_EXPORT extern const base::Feature kV8OptimizeJavascript;
GIN_EXPORT extern const base::Feature kV8FlushBytecode; GIN_EXPORT extern const base::Feature kV8FlushBytecode;
GIN_EXPORT extern const base::Feature kV8MemoryReducerForSmallHeaps; GIN_EXPORT extern const base::Feature kV8MemoryReducerForSmallHeaps;
GIN_EXPORT extern const base::Feature kV8HugeMaxOldGenerationSize;
} // namespace features } // namespace features
......
...@@ -232,13 +232,6 @@ void V8Initializer::Initialize(IsolateHolder::ScriptMode mode) { ...@@ -232,13 +232,6 @@ void V8Initializer::Initialize(IsolateHolder::ScriptMode mode) {
sizeof(no_memory_reducer) - 1); sizeof(no_memory_reducer) - 1);
} }
if (base::FeatureList::IsEnabled(features::kV8HugeMaxOldGenerationSize)) {
static const char huge_max_old_generation_size[] =
"--huge_max_old_generation_size";
v8::V8::SetFlagsFromString(huge_max_old_generation_size,
sizeof(huge_max_old_generation_size) - 1);
}
if (IsolateHolder::kStrictMode == mode) { if (IsolateHolder::kStrictMode == mode) {
static const char use_strict[] = "--use_strict"; static const char use_strict[] = "--use_strict";
v8::V8::SetFlagsFromString(use_strict, sizeof(use_strict) - 1); v8::V8::SetFlagsFromString(use_strict, sizeof(use_strict) - 1);
......
...@@ -5419,25 +5419,6 @@ ...@@ -5419,25 +5419,6 @@
] ]
} }
], ],
"V8HugeMaxOldGenerationSize": [
{
"platforms": [
"android",
"chromeos",
"linux",
"mac",
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"V8HugeMaxOldGenerationSize"
]
}
]
}
],
"V8Ignition": [ "V8Ignition": [
{ {
"platforms": [ "platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment