[ios] Add Messages Overlay Testing Config

Bug: 1071914
Change-Id: I27d71af8635d3c232a4f1562a7da5c61431efee2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324884Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797672}

ios/chrome/browser/translate/BUILD.gn

@@ -108,38 +108,6 @@ source_set("unit_tests") {
   ]
 }
 
-source_set("eg2_tests") {
-  defines = [ "CHROME_EARL_GREY_2" ]
-  configs += [
-    "//build/config/compiler:enable_arc",
-    "//build/config/ios:xctest_config",
-  ]
-  testonly = true
-  sources = [ "translate_egtest.mm" ]
-  deps = [
-    ":eg_test_support+eg2",
-    "//base/test:test_support",
-    "//components/strings:components_strings_grit",
-    "//components/translate/core/browser:browser",
-    "//components/translate/core/common:common",
-    "//ios/chrome/app/strings:ios_strings_grit",
-    "//ios/chrome/browser:chrome_url_constants",
-    "//ios/chrome/browser/ui/infobars:feature_flags",
-    "//ios/chrome/browser/ui/popup_menu:constants",
-    "//ios/chrome/browser/ui/translate:legacy_translate_constants",
-    "//ios/chrome/browser/ui/translate:translate_ui_constants",
-    "//ios/chrome/test/earl_grey:eg_test_support+eg2",
-    "//ios/components/webui:url_constants",
-    "//ios/testing/earl_grey:eg_test_support+eg2",
-    "//ios/third_party/earl_grey2:test_lib",
-    "//ios/web/public:public",
-    "//ios/web/public/test/http_server:http_server",
-    "//ui/base:base",
-    "//url:url",
-  ]
-  frameworks = [ "UIKit.framework" ]
-}
-
 source_set("test_support") {
   testonly = true
   sources = [

ios/chrome/browser/ui/overlays/infobar_banner/confirm/confirm_infobar_banner_overlay_mediator.mm

@@ -53,8 +53,6 @@ using confirm_infobar_overlays::ConfirmBannerRequestConfig;
   if (!self.consumer || !config)
     return;
 
-  [self.consumer setBannerAccessibilityLabel:base::SysUTF16ToNSString(
-                                                 config->button_label_text())];
   [self.consumer
       setButtonText:base::SysUTF16ToNSString(config->button_label_text())];
   if (!config->icon_image().IsEmpty())

ios/chrome/browser/ui/overlays/infobar_banner/save_card/save_card_infobar_banner_overlay_mediator.mm

@@ -73,8 +73,6 @@ using save_card_infobar_overlays::SaveCardMainAction;
   if (!self.consumer || !config)
     return;
 
-  [self.consumer setBannerAccessibilityLabel:base::SysUTF16ToNSString(
-                                                 config->button_label_text())];
   [self.consumer
       setButtonText:base::SysUTF16ToNSString(self.config->button_label_text())];
   [self.consumer setIconImage:[UIImage imageNamed:config->icon_image_name()]];

ios/chrome/browser/ui/page_info/page_info_legacy_coordinator.mm

@@ -87,13 +87,14 @@
 
   CGPoint originPresentationCoordinates = [self.presentationProvider
       convertToPresentationCoordinatesForOrigin:self.originPoint];
+  // TODO(crbug.com/1045047): Use HandlerForProtocol() when BrowserCommands is
+  // broken up.
   self.pageInfoViewController = [[LegacyPageInfoViewController alloc]
              initWithModel:config
                sourcePoint:originPresentationCoordinates
       presentationProvider:self.presentationProvider
-                   handler:HandlerForProtocol(
-                               self.browser->GetCommandDispatcher(),
-                               BrowserCommands)];
+                   handler:static_cast<id<BrowserCommands>>(
+                               self.browser->GetCommandDispatcher())];
 }
 
 - (void)stop {

ios/chrome/test/earl_grey2/BUILD.gn

@@ -84,7 +84,6 @@ chrome_ios_eg2_test("ios_chrome_integration_eg2tests_module") {
     "//ios/chrome/browser/policy_url_blocking:eg2_tests",
     "//ios/chrome/browser/prerender:eg2_tests",
     "//ios/chrome/browser/safe_browsing:eg2_tests",
-    "//ios/chrome/browser/translate:eg2_tests",
     "//ios/chrome/browser/ui/autofill:eg2_tests",
     "//ios/chrome/browser/ui/autofill/manual_fill:eg2_tests",
     "//ios/chrome/browser/ui/content_suggestions:eg2_tests",

testing/variations/fieldtrial_testing_config.json

@@ -3545,6 +3545,21 @@
             ]
         }
     ],
+    "IOSMessagesOverlay": [
+        {
+            "platforms": [
+                "ios"
+            ],
+            "experiments": [
+                {
+                    "name": "Enabled",
+                    "enable_features": [
+                        "InfobarOverlayUI"
+                    ]
+                }
+            ]
+        }
+    ],
     "IOSPageInfoRefactoring": [
         {
             "platforms": [