Migrate DeprecatedEqual to EqualASCII for all other ASCII literals
This CL migrates the remaining comparisons involving an ASCII literal from DeprecatedEqualIgnoringCase to EqualIgnoringASCIICase (except the comparisons being reviewed under <https://crrev.com/c/2106983>). These changes are potentially author-facing, but I’ve optimistically made them without any additional tests based on Rick Byers’ reasoning on blink-dev [1]. Please let me know if that’s not sufficient here. The engine changes are a curated subset of the following replacement under Sublime Text 2 (PCRE): Find: (?x-i) (?<escape>\\['"?\\abfnrtv]){0} (?<literal>"(?:(?=[ -~])[^"]|(?&escape))*"){0} (?<any>(?:[^(),]|(\((?:[^()]*|(?-1))\)))*+){0} DeprecatedEqualIgnoringCase (\s*\(\s*+(?: (?&literal)\s*,\s*+(?&any) |(?&any)\s*,\s*+(?&literal) )\s*\)) Where: *.cc,-/path/to/src/out/*,-/path/to/src/.clangd/* Replace: EqualIgnoringASCIICase$5 [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/sFOpNuQ91UU/3u1HxbnQCQAJ Change-Id: If6e1963da8128e3044df38f1924d98089e7d215a Bug: 627682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108441 Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by:Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#751346}
Showing
Please register or sign in to comment