[PwdCheckAndroid] Enable password check by default

Bug: 1092444
Change-Id: I6e22b168718cb6271171d4a219301e9fa2f55101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516541
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823935}

chrome/browser/password_check/android/password_check_manager_unittest.cc

@@ -69,6 +69,8 @@ constexpr char kUsername2[] = "bob";
 
 constexpr char kPassword1[] = "s3cre3t";
 
+constexpr char kTestEmail[] = "user@gmail.com";
+
 class MockPasswordCheckManagerObserver : public PasswordCheckManager::Observer {
  public:
   MOCK_METHOD(void, OnSavedPasswordsFetched, (int), (override));
@@ -217,6 +219,9 @@ class PasswordCheckManagerTest : public testing::Test {
 
   void RunUntilIdle() { task_env_.RunUntilIdle(); }
 
+  signin::IdentityTestEnvironment& identity_test_env() {
+    return identity_test_env_;
+  }
   BulkLeakCheckService* service() { return service_; }
   TestPasswordStore& store() { return *store_; }
   MockPasswordCheckManagerObserver& mock_observer() { return mock_observer_; }
@@ -277,6 +282,7 @@ TEST_F(PasswordCheckManagerTest, OnCompromisedCredentialsChanged) {
 }
 
 TEST_F(PasswordCheckManagerTest, RunCheckAfterLastInitialization) {
+  identity_test_env().MakeAccountAvailable(kTestEmail);
   EXPECT_CALL(mock_observer(), OnPasswordCheckStatusChanged(_))
       .Times(AtLeast(1));
   EXPECT_CALL(mock_observer(), OnSavedPasswordsFetched(1));
@@ -300,6 +306,7 @@ TEST_F(PasswordCheckManagerTest, RunCheckAfterLastInitialization) {
 
 TEST_F(PasswordCheckManagerTest,
        RunCheckAfterLastInitializationAutomaticChangeOn) {
+  identity_test_env().MakeAccountAvailable(kTestEmail);
   // Enable password sync
   sync_service().SetActiveDataTypes(syncer::ModelTypeSet(syncer::PASSWORDS));
   feature_list().InitWithFeatures(
@@ -382,6 +389,7 @@ TEST_F(PasswordCheckManagerTest, CorrectlyCreatesUIStructForAppCredentials) {
 }
 
 TEST_F(PasswordCheckManagerTest, SetsTimestampOnSuccessfulCheck) {
+  identity_test_env().MakeAccountAvailable(kTestEmail);
   InitializeManager();
   store().AddLogin(MakeSavedPassword(kExampleCom, kUsername1));
   RunUntilIdle();
@@ -395,6 +403,7 @@ TEST_F(PasswordCheckManagerTest, SetsTimestampOnSuccessfulCheck) {
 }
 
 TEST_F(PasswordCheckManagerTest, DoesntRecordTimestampOfUnsuccessfulCheck) {
+  identity_test_env().MakeAccountAvailable(kTestEmail);
   InitializeManager();
   store().AddLogin(MakeSavedPassword(kExampleCom, kUsername1));
   RunUntilIdle();
@@ -569,6 +578,7 @@ TEST_F(PasswordCheckManagerTest,
 }
 
 TEST_F(PasswordCheckManagerTest, UpdatesProgressCorrectly) {
+  identity_test_env().MakeAccountAvailable(kTestEmail);
   InitializeManager();
   store().AddLogin(MakeSavedPassword(kExampleCom, kUsername1, kPassword1));
   store().AddLogin(MakeSavedPassword(kExampleOrg, kUsername1, kPassword1));

components/password_manager/core/browser/leak_detection_dialog_utils_unittest.cc

@@ -284,16 +284,16 @@ struct PasswordChangeParams {
      false, false},
     {CreateLeakType(IsSaved(false), IsReused(false), IsSyncing(true)), IDS_OK,
      false, false},
-    {CreateLeakType(IsSaved(false), IsReused(true), IsSyncing(false)), IDS_OK,
-     false, false},
+    {CreateLeakType(IsSaved(false), IsReused(true), IsSyncing(false)),
+     IDS_LEAK_CHECK_CREDENTIALS, true, false},
     {CreateLeakType(IsSaved(false), IsReused(true), IsSyncing(true)),
      IDS_LEAK_CHECK_CREDENTIALS, true, false},
     {CreateLeakType(IsSaved(true), IsReused(false), IsSyncing(false)), IDS_OK,
      false, false},
     {CreateLeakType(IsSaved(true), IsReused(false), IsSyncing(true)),
      IDS_PASSWORD_CHANGE, true, true},
-    {CreateLeakType(IsSaved(true), IsReused(true), IsSyncing(false)), IDS_OK,
-     false, false},
+    {CreateLeakType(IsSaved(true), IsReused(true), IsSyncing(false)),
+     IDS_LEAK_CHECK_CREDENTIALS, true, false},
     {CreateLeakType(IsSaved(true), IsReused(true), IsSyncing(true)),
      IDS_LEAK_CHECK_CREDENTIALS, true, false}};
 

components/password_manager/core/common/password_manager_features.cc

@@ -65,12 +65,7 @@ const base::Feature kPasswordChangeInSettings = {
 
 // Enables the bulk Password Check feature for signed in users.
 const base::Feature kPasswordCheck = {"PasswordCheck",
-#if defined(OS_ANDROID)
-                                      base::FEATURE_DISABLED_BY_DEFAULT
-#else
-                                      base::FEATURE_ENABLED_BY_DEFAULT
-#endif
-};
+                                      base::FEATURE_ENABLED_BY_DEFAULT};
 
 // Controls the ability to import passwords from Chrome's settings page.
 const base::Feature kPasswordImport = {"PasswordImport",