Commit 4ad7186c authored by Ewann's avatar Ewann Committed by Commit Bot

Adds metrics for opening Downloads folder.

user actions:
-Adds MobileDownloadFolderUIShownFromDownloadManager
-Adds MobileDownloadFolderUIShownFromToolsMenu

Bug: 1013572
Change-Id: Iee1697a330b37c0ca5501928f01a25ca17062140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970993Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733948}
parent 98b02768
...@@ -4,6 +4,8 @@ ...@@ -4,6 +4,8 @@
#import "ios/chrome/browser/ui/download/activities/open_downloads_folder_activity.h" #import "ios/chrome/browser/ui/download/activities/open_downloads_folder_activity.h"
#include "base/metrics/user_metrics.h"
#include "base/metrics/user_metrics_action.h"
#import "ios/chrome/browser/ui/commands/browser_commands.h" #import "ios/chrome/browser/ui/commands/browser_commands.h"
#include "ios/chrome/grit/ios_strings.h" #include "ios/chrome/grit/ios_strings.h"
#include "ui/base/l10n/l10n_util_mac.h" #include "ui/base/l10n/l10n_util_mac.h"
...@@ -49,6 +51,8 @@ NSString* const kOpenDownloadsFolderActivityType = ...@@ -49,6 +51,8 @@ NSString* const kOpenDownloadsFolderActivityType =
} }
- (void)performActivity { - (void)performActivity {
base::RecordAction(base::UserMetricsAction(
"MobileDownloadFolderUIShownFromDownloadManager"));
[self.browserHandler showDownloadsFolder]; [self.browserHandler showDownloadsFolder];
[self activityDidFinish:YES]; [self activityDidFinish:YES];
} }
......
...@@ -106,6 +106,8 @@ using base::UserMetricsAction; ...@@ -106,6 +106,8 @@ using base::UserMetricsAction;
[self.dispatcher showHelpPage]; [self.dispatcher showHelpPage];
break; break;
case PopupMenuActionOpenDownloads: case PopupMenuActionOpenDownloads:
RecordAction(
UserMetricsAction("MobileDownloadFolderUIShownFromToolsMenu"));
[self.dispatcher showDownloadsFolder]; [self.dispatcher showDownloadsFolder];
break; break;
case PopupMenuActionTextZoom: case PopupMenuActionTextZoom:
......
...@@ -12315,6 +12315,22 @@ should be able to be added at any place in this file. ...@@ -12315,6 +12315,22 @@ should be able to be added at any place in this file.
<description>User was presented with the Download file UI.</description> <description>User was presented with the Download file UI.</description>
</action> </action>
<action name="MobileDownloadFolderUIShownFromDownloadManager">
<owner>ewannpv@chromium.org</owner>
<owner>gambard@chromium.org</owner>
<description>
User pressed &quot;Open in Downloads&quot; button from the download manager.
</description>
</action>
<action name="MobileDownloadFolderUIShownFromToolsMenu">
<owner>ewannpv@chromium.org</owner>
<owner>gambard@chromium.org</owner>
<description>
User pressed &quot;Downloads&quot; button from the tools menu.
</description>
</action>
<action name="MobileDownloadRetryDownload"> <action name="MobileDownloadRetryDownload">
<owner>eugenebut@chromium.org</owner> <owner>eugenebut@chromium.org</owner>
<description> <description>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment