Commit 4ae3d8f6 authored by Eric Seckler's avatar Eric Seckler Committed by Commit Bot

blink scheduler: Record UMA for load after fifth minute in background.

We intend to use this new histogram to trigger slow reports for users
where load of a background tab is high.

Bug: 848691
Change-Id: I7dd524f77a8be3f86e0678f0a4c1711d6b077779
Reviewed-on: https://chromium-review.googlesource.com/1082393Reviewed-by: default avatarSami Kyöstilä <skyostil@chromium.org>
Reviewed-by: default avatarRobert Kaplow <rkaplow@chromium.org>
Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563629}
parent 33a2fbca
...@@ -445,9 +445,10 @@ void MainThreadMetricsHelper::RecordForegroundMainThreadTaskLoad( ...@@ -445,9 +445,10 @@ void MainThreadMetricsHelper::RecordForegroundMainThreadTaskLoad(
UMA_HISTOGRAM_PERCENTAGE(MAIN_THREAD_LOAD_METRIC_NAME ".Foreground", UMA_HISTOGRAM_PERCENTAGE(MAIN_THREAD_LOAD_METRIC_NAME ".Foreground",
load_percentage); load_percentage);
if (time - main_thread_scheduler_->main_thread_only() base::TimeDelta time_since_foregrounded =
.background_status_changed_at > time - main_thread_scheduler_->main_thread_only()
base::TimeDelta::FromMinutes(1)) { .background_status_changed_at;
if (time_since_foregrounded > base::TimeDelta::FromMinutes(1)) {
UMA_HISTOGRAM_PERCENTAGE(MAIN_THREAD_LOAD_METRIC_NAME UMA_HISTOGRAM_PERCENTAGE(MAIN_THREAD_LOAD_METRIC_NAME
".Foreground.AfterFirstMinute", ".Foreground.AfterFirstMinute",
load_percentage); load_percentage);
...@@ -476,13 +477,19 @@ void MainThreadMetricsHelper::RecordBackgroundMainThreadTaskLoad( ...@@ -476,13 +477,19 @@ void MainThreadMetricsHelper::RecordBackgroundMainThreadTaskLoad(
UMA_HISTOGRAM_PERCENTAGE(MAIN_THREAD_LOAD_METRIC_NAME ".Background", UMA_HISTOGRAM_PERCENTAGE(MAIN_THREAD_LOAD_METRIC_NAME ".Background",
load_percentage); load_percentage);
if (time - main_thread_scheduler_->main_thread_only() base::TimeDelta time_since_backgrounded =
.background_status_changed_at > time - main_thread_scheduler_->main_thread_only()
base::TimeDelta::FromMinutes(1)) { .background_status_changed_at;
if (time_since_backgrounded > base::TimeDelta::FromMinutes(1)) {
UMA_HISTOGRAM_PERCENTAGE(MAIN_THREAD_LOAD_METRIC_NAME UMA_HISTOGRAM_PERCENTAGE(MAIN_THREAD_LOAD_METRIC_NAME
".Background.AfterFirstMinute", ".Background.AfterFirstMinute",
load_percentage); load_percentage);
} }
if (time_since_backgrounded > base::TimeDelta::FromMinutes(5)) {
UMA_HISTOGRAM_PERCENTAGE(MAIN_THREAD_LOAD_METRIC_NAME
".Background.AfterFifthMinute",
load_percentage);
}
break; break;
} }
......
...@@ -119979,6 +119979,9 @@ uploading your change for review. ...@@ -119979,6 +119979,9 @@ uploading your change for review.
<suffix name="Background" <suffix name="Background"
label="Main thread load when the renderer is backgrounded. This does label="Main thread load when the renderer is backgrounded. This does
not include extension renderers."/> not include extension renderers."/>
<suffix name="Background.AfterFifthMinute"
label="Main thread load when the renderer is backgrounded for longer
than five minutes. This does not include extension renderers."/>
<suffix name="Background.AfterFirstMinute" <suffix name="Background.AfterFirstMinute"
label="Main thread load when the renderer is backgrounded for longer label="Main thread load when the renderer is backgrounded for longer
than one minute. Most of loading tasks are expected to complete than one minute. Most of loading tasks are expected to complete
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment