Commit 4afb3ed1 authored by miguelg@chromium.org's avatar miguelg@chromium.org

Only grant MidiSysExMessage if needed.

It seems that right now we are granting it to child policy process even if the permission was not granted.
Rename the success parameter to is_allowed. To match what the renderer expects.

TBR=tsepez,dalecurtis
BUG=

Review URL: https://codereview.chromium.org/329993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276720 0039d316-1c4b-4281-b951-d872f2087c98
parent 8eaba2dd
...@@ -72,10 +72,12 @@ void MidiDispatcherHost::OnCancelSysExPermissionRequest( ...@@ -72,10 +72,12 @@ void MidiDispatcherHost::OnCancelSysExPermissionRequest(
} }
void MidiDispatcherHost::WasSysExPermissionGranted(int render_view_id, void MidiDispatcherHost::WasSysExPermissionGranted(int render_view_id,
int bridge_id, int bridge_id,
bool success) { bool is_allowed) {
ChildProcessSecurityPolicyImpl::GetInstance()->GrantSendMidiSysExMessage( if (is_allowed)
render_process_id_); ChildProcessSecurityPolicyImpl::GetInstance()->GrantSendMidiSysExMessage(
Send(new MidiMsg_SysExPermissionApproved(render_view_id, bridge_id, success)); render_process_id_);
Send(new MidiMsg_SysExPermissionApproved(
render_view_id, bridge_id, is_allowed));
} }
} // namespace content } // namespace content
...@@ -38,7 +38,7 @@ class MidiDispatcherHost : public BrowserMessageFilter { ...@@ -38,7 +38,7 @@ class MidiDispatcherHost : public BrowserMessageFilter {
const GURL& requesting_frame); const GURL& requesting_frame);
void WasSysExPermissionGranted(int render_view_id, void WasSysExPermissionGranted(int render_view_id,
int bridge_id, int bridge_id,
bool success); bool is_allowed);
int render_process_id_; int render_process_id_;
BrowserContext* browser_context_; BrowserContext* browser_context_;
......
...@@ -45,7 +45,7 @@ IPC_MESSAGE_CONTROL3(MidiHostMsg_CancelSysExPermissionRequest, ...@@ -45,7 +45,7 @@ IPC_MESSAGE_CONTROL3(MidiHostMsg_CancelSysExPermissionRequest,
IPC_MESSAGE_ROUTED2(MidiMsg_SysExPermissionApproved, IPC_MESSAGE_ROUTED2(MidiMsg_SysExPermissionApproved,
int /* client id */, int /* client id */,
bool /* success */) bool /* is_allowed */)
// Messages for IPC between MidiMessageFilter and MidiHost. // Messages for IPC between MidiMessageFilter and MidiHost.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment