disallow selection by double clicking on chromium tab

See the bug for details about why.

Bug: 1127496
Change-Id: I73978517810d1061c9662d2f051953baf3806e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413289
Commit-Queue: Elaine Chien <elainec@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807533}

chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_test_api.cc

@@ -13,6 +13,7 @@
 #include "ui/views/controls/button/checkbox.h"
 #include "ui/views/controls/tabbed_pane/tabbed_pane.h"
 #include "ui/views/controls/table/table_view.h"
+#include "ui/views/controls/table/table_view_observer.h"
 
 namespace {
 
@@ -57,6 +58,9 @@ void DesktopMediaPickerViewsTestApi::PressMouseOnSourceAtIndex(
     // within a larger view would be breakage-prone; just ask the TableView to
     // to select.
     GetTableView()->Select(index);
+    if (double_click) {
+      GetTableView()->observer()->OnDoubleClick();
+    }
   }
 }
 

chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc

@@ -12,6 +12,8 @@
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/task/post_task.h"
+#include "base/threading/thread_task_runner_handle.h"
 #include "build/build_config.h"
 #include "chrome/browser/media/webrtc/desktop_media_picker_manager.h"
 #include "chrome/browser/media/webrtc/fake_desktop_media_list.h"
@@ -200,6 +202,11 @@ TEST_F(DesktopMediaPickerViewsTest, DoneCallbackNotCalledOnDoubleClick) {
   test_api_.GetAudioShareCheckbox()->SetChecked(false);
 
   test_api_.PressMouseOnSourceAtIndex(0, true);
+
+  base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
+                                                run_loop_.QuitClosure());
+  run_loop_.Run();
+
   EXPECT_FALSE(picked_id().has_value());
 }
 

chrome/browser/ui/views/desktop_capture/desktop_media_tab_list.cc

@@ -91,7 +91,6 @@ class TabListViewObserver : public views::TableViewObserver {
   explicit TabListViewObserver(DesktopMediaListController* controller);
 
   void OnSelectionChanged() override;
-  void OnDoubleClick() override;
   void OnKeyDown(ui::KeyboardCode virtual_keycode) override;
 
  private:
@@ -108,10 +107,6 @@ void TabListViewObserver::OnSelectionChanged() {
   controller_->OnSourceSelectionChanged();
 }
 
-void TabListViewObserver::OnDoubleClick() {
-  controller_->AcceptSource();
-}
-
 void TabListViewObserver::OnKeyDown(ui::KeyboardCode virtual_keycode) {
   if (virtual_keycode == ui::VKEY_RETURN)
     controller_->AcceptSource();