Skip to content

GitLab

T
tangled
Commit 4b0d7dec authored by Ethan Kuefner's avatar Ethan Kuefner Committed by Commit Bot
Browse files
Options

[Perf] Flip flag for histogram pipeline 

We have already whitelisted enough benchmarks that we want to flip the flag
for all Telemetry benchmarks. system_health was the largest benchmark so we
don't expect to encounter request deadline issues on the perf dashboard
side.

Bug: 744736
Change-Id: I62ce9511a32a56b3eb33bc35bdd6e487f135083f
Reviewed-on: https://chromium-review.googlesource.com/1070219
Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
Reviewed-by: default avatarEmily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562610}
parent 58c02f4c
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 319 additions and 470 deletions
testing/buildbot/chromium.perf.json
View file @ 4b0d7dec
This diff is collapsed.
testing/scripts/run_performance_tests.py
View file @ 4b0d7dec
......@@ -57,77 +57,6 @@ import common
import run_telemetry_benchmark_as_googletest
import run_gtest_perf_test
# Current whitelist of benchmarks outputting histograms
BENCHMARKS_TO_OUTPUT_HISTOGRAMS = [
'dummy_benchmark.histogram_benchmark_1',
'blink_perf.bindings',
'blink_perf.canvas',
'blink_perf.css',
'blink_perf.dom',
'blink_perf.events',
'blink_perf.image_decoder',
'blink_perf.layout',
'blink_perf.owp_storage',
'blink_perf.paint',
'blink_perf.parser',
'blink_perf.shadow_dom',
'blink_perf.svg',
'memory.top_10_mobile',
'system_health.common_desktop',
'system_health.common_mobile',
'system_health.memory_desktop',
'system_health.memory_mobile',
'system_health.webview_startup',
'smoothness.gpu_rasterization.tough_filters_cases',
'smoothness.gpu_rasterization.tough_path_rendering_cases',
'smoothness.gpu_rasterization.tough_scrolling_cases',
'smoothness.gpu_rasterization_and_decoding.image_decoding_cases',
'smoothness.image_decoding_cases',
'smoothness.key_desktop_move_cases',
'smoothness.maps',
'smoothness.oop_rasterization.top_25_smooth',
'smoothness.top_25_smooth',
'smoothness.tough_ad_cases',
'smoothness.tough_animation_cases',
'smoothness.tough_canvas_cases',
'smoothness.tough_filters_cases',
'smoothness.tough_image_decode_cases',
'smoothness.tough_path_rendering_cases',
'smoothness.tough_scrolling_cases',
'smoothness.tough_texture_upload_cases',
'smoothness.tough_webgl_ad_cases',
'smoothness.tough_webgl_cases',
'dromaeo',
'jetstream',
'kraken',
'octane',
'speedometer',
'speedometer-future',
'speedometer2',
'speedometer2-future',
'wasm',
'battor.steady_state',
'battor.trivial_pages',
'rasterize_and_record_micro.partial_invalidation',
'rasterize_and_record_micro.top_25',
'scheduler.tough_scheduling_cases',
'tab_switching.typical_25',
'thread_times.key_hit_test_cases',
'thread_times.key_idle_power_cases',
'thread_times.key_mobile_sites_smooth',
'thread_times.key_noop_cases',
'thread_times.key_silk_cases',
'thread_times.simple_mobile_sites',
'thread_times.oop_rasterization.key_mobile',
'thread_times.tough_compositor_cases',
'thread_times.tough_scrolling_cases',
'tracing.tracing_with_background_memory_infra',
'tracing.tracing_with_debug_overhead',
'v8.browsing_desktop',
'v8.browsing_mobile',
'v8.browsing_desktop-future',
'v8.browsing_mobile-future',
]
def get_sharding_map_path(args):
return os.path.join(
......@@ -159,7 +88,7 @@ def execute_benchmark(benchmark, isolated_out_dir,
# to determine which output format to look for or see if it was
# already passed in in which case that format applies to all benchmarks
# in this run.
is_histograms = append_output_format(benchmark, args, rest_args)
is_histograms = append_output_format(args, rest_args)
# Insert benchmark name as first argument to run_benchmark call
# which is the first argument in the rest_args. Also need to append
# output format and smoke test mode.
......@@ -202,7 +131,7 @@ def execute_benchmark(benchmark, isolated_out_dir,
return rc
def append_output_format(benchmark, args, rest_args):
def append_output_format(args, rest_args):
# We need to determine if the output format is already passed in
# or if we need to define it for this benchmark
perf_output_specified = False
......@@ -219,11 +148,8 @@ def append_output_format(benchmark, args, rest_args):
# the type of format per benchmark and can rely on it being passed
# in as an arg as all benchmarks will output the same format.
if not perf_output_specified:
if benchmark in BENCHMARKS_TO_OUTPUT_HISTOGRAMS:
rest_args.append('--output-format=histograms')
is_histograms = True
else:
rest_args.append('--output-format=chartjson')
rest_args.append('--output-format=histograms')
is_histograms = True
return is_histograms
def main():
......
tools/perf/core/perf_data_generator.py
View file @ 4b0d7dec
......@@ -450,79 +450,6 @@ def generate_isolate_script_entry(swarming_dimensions, test_args,
return result
BENCHMARKS_TO_OUTPUT_HISTOGRAMS = [
'dummy_benchmark.noisy_benchmark_1',
'dummy_benchmark.stable_benchmark_1',
'blink_perf.bindings',
'blink_perf.canvas',
'blink_perf.css',
'blink_perf.dom',
'blink_perf.events',
'blink_perf.image_decoder',
'blink_perf.layout',
'blink_perf.owp_storage',
'blink_perf.paint',
'blink_perf.parser',
'blink_perf.shadow_dom',
'blink_perf.svg',
'memory.top_10_mobile',
'system_health.common_desktop',
'system_health.common_mobile',
'system_health.memory_desktop',
'system_health.memory_mobile',
'system_health.webview_startup',
'smoothness.gpu_rasterization.tough_filters_cases',
'smoothness.gpu_rasterization.tough_path_rendering_cases',
'smoothness.gpu_rasterization.tough_scrolling_cases',
'smoothness.gpu_rasterization_and_decoding.image_decoding_cases',
'smoothness.image_decoding_cases',
'smoothness.key_desktop_move_cases',
'smoothness.maps',
'smoothness.oop_rasterization.top_25_smooth',
'smoothness.top_25_smooth',
'smoothness.tough_ad_cases',
'smoothness.tough_animation_cases',
'smoothness.tough_canvas_cases',
'smoothness.tough_filters_cases',
'smoothness.tough_image_decode_cases',
'smoothness.tough_path_rendering_cases',
'smoothness.tough_scrolling_cases',
'smoothness.tough_texture_upload_cases',
'smoothness.tough_webgl_ad_cases',
'smoothness.tough_webgl_cases',
'dromaeo',
'jetstream',
'kraken',
'octane',
'speedometer',
'speedometer-future',
'speedometer2',
'speedometer2-future',
'wasm',
'battor.steady_state',
'battor.trivial_pages',
'rasterize_and_record_micro.partial_invalidation',
'rasterize_and_record_micro.top_25',
'scheduler.tough_scheduling_cases',
'tab_switching.typical_25',
'thread_times.key_hit_test_cases',
'thread_times.key_idle_power_cases',
'thread_times.key_mobile_sites_smooth',
'thread_times.key_noop_cases',
'thread_times.key_silk_cases',
'thread_times.simple_mobile_sites',
'thread_times.oop_rasterization.key_mobile',
'thread_times.tough_compositor_cases',
'thread_times.tough_scrolling_cases',
'tracing.tracing_with_background_memory_infra',
'tracing.tracing_with_debug_overhead',
'v8.browsing_desktop',
'v8.browsing_mobile',
'v8.browsing_desktop-future',
'v8.browsing_mobile-future',
]
def generate_telemetry_test(swarming_dimensions, benchmark_name, browser):
# The step name must end in 'test' or 'tests' in order for the
# results to automatically show up on the flakiness dashboard.
......@@ -533,16 +460,12 @@ def generate_telemetry_test(swarming_dimensions, benchmark_name, browser):
benchmark_name,
'-v',
'--upload-results',
'--browser=%s' % browser
'--browser=%s' % browser,
'--output-format=histograms',
]
# When this is enabled on more than just windows machines we will need
# --device=android
if benchmark_name in BENCHMARKS_TO_OUTPUT_HISTOGRAMS:
test_args.append('--output-format=histograms')
else:
test_args.append('--output-format=chartjson')
ignore_task_failure = False
step_name = benchmark_name
if browser == 'reference':
......
tools/perf/core/perf_data_generator_unittest.py
View file @ 4b0d7dec
......@@ -145,7 +145,7 @@ class PerfDataGeneratorTest(unittest.TestCase):
test = tests[0]
self.assertEquals(test['args'], [
'regular', '-v', '--upload-results',
'--browser=android-webview', '--output-format=chartjson',
'--browser=android-webview', '--output-format=histograms',
'--webview-embedder-apk=../../out/Release/apks/SystemWebViewShell.apk'])
self.assertEquals(test['isolate_name'], 'telemetry_perf_webview_tests')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment