Commit 4b0e7b4a authored by Ryan Hansberry's avatar Ryan Hansberry Committed by Commit Bot

Restore emission of ContinueReading bucket in metrics.

Additionally, rearrange call sites to match the order of the
BuiltInAppName enum.

Fixed: 1049370
Change-Id: I260a0827a4c1f78a153713d5bea74343161ab740
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040114
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: default avatarNancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738814}
parent 761372e6
......@@ -139,39 +139,45 @@ void RecordAppLaunch(const std::string& app_id,
// Above are default Essential apps; below are built-in apps.
else if (app_id == ash::kInternalAppIdKeyboardShortcutViewer)
if (app_id == ash::kInternalAppIdKeyboardShortcutViewer) {
RecordBuiltInAppLaunch(BuiltInAppName::kKeyboardShortcutViewer,
launch_source);
else if (app_id == ash::kReleaseNotesAppId)
RecordBuiltInAppLaunch(BuiltInAppName::kReleaseNotes, launch_source);
else if (app_id == ash::kInternalAppIdDiscover)
RecordBuiltInAppLaunch(BuiltInAppName::kDiscover, launch_source);
else if (app_id == ash::kInternalAppIdSettings)
} else if (app_id == ash::kInternalAppIdSettings) {
RecordBuiltInAppLaunch(BuiltInAppName::kSettings, launch_source);
} else if (app_id == ash::kInternalAppIdContinueReading) {
RecordBuiltInAppLaunch(BuiltInAppName::kContinueReading, launch_source);
} else if (app_id == ash::kInternalAppIdDiscover) {
RecordBuiltInAppLaunch(BuiltInAppName::kDiscover, launch_source);
#if defined(OS_CHROMEOS)
else if (app_id == plugin_vm::kPluginVmAppId)
} else if (app_id == plugin_vm::kPluginVmAppId) {
RecordBuiltInAppLaunch(BuiltInAppName::kPluginVm, launch_source);
#endif // OS_CHROMEOS
} else if (app_id == ash::kReleaseNotesAppId) {
RecordBuiltInAppLaunch(BuiltInAppName::kReleaseNotes, launch_source);
}
}
void RecordBuiltInAppSearchResult(const std::string& app_id) {
if (app_id == ash::kInternalAppIdKeyboardShortcutViewer) {
UMA_HISTOGRAM_ENUMERATION("Apps.AppListSearchResultInternalApp.Show",
BuiltInAppName::kKeyboardShortcutViewer);
} else if (app_id == ash::kReleaseNotesAppId) {
} else if (app_id == ash::kInternalAppIdSettings) {
UMA_HISTOGRAM_ENUMERATION("Apps.AppListSearchResultInternalApp.Show",
BuiltInAppName::kReleaseNotes);
BuiltInAppName::kSettings);
} else if (app_id == ash::kInternalAppIdContinueReading) {
UMA_HISTOGRAM_ENUMERATION("Apps.AppListSearchResultInternalApp.Show",
BuiltInAppName::kContinueReading);
} else if (app_id == ash::kInternalAppIdDiscover) {
UMA_HISTOGRAM_ENUMERATION("Apps.AppListSearchResultInternalApp.Show",
BuiltInAppName::kDiscover);
} else if (app_id == ash::kInternalAppIdSettings) {
UMA_HISTOGRAM_ENUMERATION("Apps.AppListSearchResultInternalApp.Show",
BuiltInAppName::kSettings);
#if defined(OS_CHROMEOS)
} else if (app_id == plugin_vm::kPluginVmAppId) {
UMA_HISTOGRAM_ENUMERATION("Apps.AppListSearchResultInternalApp.Show",
BuiltInAppName::kPluginVm);
#endif // OS_CHROMEOS
} else if (app_id == ash::kReleaseNotesAppId) {
UMA_HISTOGRAM_ENUMERATION("Apps.AppListSearchResultInternalApp.Show",
BuiltInAppName::kReleaseNotes);
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment