Commit 4b16517a authored by Javier Ernesto Flores Robles's avatar Javier Ernesto Flores Robles Committed by Commit Bot

[iOS][Test-Flaky] Mark web unit tests as flaky

Marking ContextMenuJsTest.FindLinkImageAtPointOutsideElement,
ContextMenuJsTest.GetImageTitleAtPoint and
ContextMenuJsFindElementAtPointTest.LinkOfTextWithoutCalloutProperty as
flaky on devices.

Bug: 796418
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1639c935a5f33cccd58a809f63f8bbeac32dcd45
TBR: eugenebut@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1174536Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582905}
parent ecf80c2f
...@@ -135,7 +135,13 @@ TEST_F(ContextMenuJsTest, GetImageUrlAtPoint) { ...@@ -135,7 +135,13 @@ TEST_F(ContextMenuJsTest, GetImageUrlAtPoint) {
} }
// Tests that __gCrWeb.getElementFromPoint function returns correct title. // Tests that __gCrWeb.getElementFromPoint function returns correct title.
TEST_F(ContextMenuJsTest, GetImageTitleAtPoint) { // TODO(crbug.com/796418): This test is flaky on devices.
#if TARGET_IPHONE_SIMULATOR
#define MAYBE_GetImageTitleAtPoint GetImageTitleAtPoint
#else
#define MAYBE_GetImageTitleAtPoint FLAKY_GetImageTitleAtPoint
#endif
TEST_F(ContextMenuJsTest, MAYBE_GetImageTitleAtPoint) {
NSString* html = NSString* html =
@"<img id='foo' title='Hello world!'" @"<img id='foo' title='Hello world!'"
"style='width:200;height:200;' src='file:///bogus'/>"; "style='width:200;height:200;' src='file:///bogus'/>";
...@@ -620,8 +626,16 @@ TEST_F(ContextMenuJsFindElementAtPointTest, ...@@ -620,8 +626,16 @@ TEST_F(ContextMenuJsFindElementAtPointTest,
// Tests that an image link does not return image and link details for a point // Tests that an image link does not return image and link details for a point
// outside the element. // outside the element.
// TODO(crbug.com/796418): This test is flaky on devices.
#if TARGET_IPHONE_SIMULATOR
#define MAYBE_FindLinkImageAtPointOutsideElement \
FindLinkImageAtPointOutsideElement
#else
#define MAYBE_FindLinkImageAtPointOutsideElement \
FLAKY_FindLinkImageAtPointOutsideElement
#endif
TEST_F(ContextMenuJsFindElementAtPointTest, TEST_F(ContextMenuJsFindElementAtPointTest,
FindLinkImageAtPointOutsideElement) { MAYBE_FindLinkImageAtPointOutsideElement) {
NSString* link_image = NSString* link_image =
@"<a href='file:///linky'>" @"<a href='file:///linky'>"
"<img id='foo' style='width:200;height:200;' src='file:///bogus'/>" "<img id='foo' style='width:200;height:200;' src='file:///bogus'/>"
...@@ -849,7 +863,15 @@ TEST_F(ContextMenuJsFindElementAtPointTest, MAYBE_LinkOfTextFromTallPage) { ...@@ -849,7 +863,15 @@ TEST_F(ContextMenuJsFindElementAtPointTest, MAYBE_LinkOfTextFromTallPage) {
// Tests that a callout information about a link is displayed when // Tests that a callout information about a link is displayed when
// -webkit-touch-callout property is not specified. Please see: // -webkit-touch-callout property is not specified. Please see:
// https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-touch-callout // https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-touch-callout
TEST_F(ContextMenuJsFindElementAtPointTest, LinkOfTextWithoutCalloutProperty) { // TODO(crbug.com/796418): This test is flaky on devices.
#if TARGET_IPHONE_SIMULATOR
#define MAYBE_LinkOfTextWithoutCalloutProperty LinkOfTextWithoutCalloutProperty
#else
#define MAYBE_LinkOfTextWithoutCalloutProperty \
FLAKY_LinkOfTextWithoutCalloutProperty
#endif
TEST_F(ContextMenuJsFindElementAtPointTest,
MAYBE_LinkOfTextWithoutCalloutProperty) {
NSString* kLinkDest = @"http://destination/"; NSString* kLinkDest = @"http://destination/";
NSString* kLinkHtml = @"<a href='%@'>link</a>"; NSString* kLinkHtml = @"<a href='%@'>link</a>";
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment