[Extensions] Update //extensions/DEPS include rules

Update the include rules for //extensions. There are many test-only
exceptions (including quite a few that violate layering). These rules
are currently applied for all tests in //extensions, but most only need
to be applied to //extensions/browser.

Trim the //extensions/DEPS include list to only have includes that are
included from multiple subdirectories, and move the rest into
//extensions/browser/DEPS and //extensions/renderer/DEPS. Also remove a
few includes that were no longer necessary, or didn't exist.

Bug: 773004

Change-Id: Ib6e705faae4472369858102e8a9ebe555e2a8d66
Reviewed-on: https://chromium-review.googlesource.com/820937
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523693}

extensions/DEPS

@@ -37,26 +37,5 @@ include_rules = [
 specific_include_rules = {
   ".*(test|test_util)\.(cc|h)$": [
     "+content/public/test",
-    "+storage/browser/test",
-
-    # Temporarily allowed testing includes.  See above.
-    # TODO(jamescook): Remove these. http://crbug.com/162530
-    "+chrome/browser/apps/app_browsertest_util.h",
-    "+chrome/browser/extensions/api/management/management_api.h",
-    "+chrome/browser/extensions/api/permissions/permissions_api.h",
-    "+chrome/browser/extensions/extension_apitest.h",
-    "+chrome/browser/extensions/extension_function_test_utils.h",
-    "+chrome/browser/extensions/extension_service.h",
-    "+chrome/browser/extensions/extension_service_test_base.h",
-    "+chrome/browser/extensions/extension_test_message_listener.h",
-    "+chrome/browser/extensions/test_extension_dir.h",
-    "+chrome/browser/extensions/test_extension_prefs.h",
-    "+chrome/browser/extensions/test_extension_system.h",
-    "+chrome/browser/ui/browser.h",
-    "+chrome/common/chrome_switches.h",
-    "+chrome/common/extensions/features/feature_channel.h",
-    "+chrome/test/base/chrome_render_view_test.h",
-    "+chrome/test/base/testing_profile.h",
-    "+chrome/test/base/ui_test_utils.h",
   ],
 }

extensions/browser/DEPS

@@ -37,7 +37,25 @@ include_rules = [
 ]
 
 specific_include_rules = {
-  ".*test\.cc$": [
+  ".*(test|test_util)\.(cc|h)$": [
     "+components/user_prefs",
-  ]
+
+    "+storage/browser/test",
+
+    # Temporarily allowed testing includes.  See above.
+    # TODO(devlin): Ideally, we'd remove these (or move the tests into
+    # //chrome). See https://crbug.com/773004.
+    "+chrome/browser/apps/app_browsertest_util.h",
+    "+chrome/browser/extensions/api/permissions/permissions_api.h",
+    "+chrome/browser/extensions/extension_apitest.h",
+    "+chrome/browser/extensions/extension_function_test_utils.h",
+    "+chrome/browser/extensions/extension_service.h",
+    "+chrome/browser/extensions/extension_service_test_base.h",
+    "+chrome/browser/extensions/extension_test_message_listener.h",
+    "+chrome/browser/extensions/test_extension_dir.h",
+    "+chrome/browser/ui/browser.h",
+    "+chrome/common/chrome_switches.h",
+    "+chrome/test/base/testing_profile.h",
+    "+chrome/test/base/ui_test_utils.h",
+  ],
 }

extensions/renderer/DEPS

@@ -24,3 +24,11 @@ include_rules = [
   "+services/service_manager/public/cpp",
 ]
 
+specific_include_rules = {
+  ".*(test|test_util)\.(cc|h)$": [
+    # Temporarily allowed testing includes.  See above.
+    # TODO(devlin): Ideally, we'd remove these (or move the tests into
+    # //chrome). See https://crbug.com/773004.
+    "+chrome/test/base/chrome_render_view_test.h",
+  ],
+}