Commit 4b25694e authored by Gheorghe Comanici's avatar Gheorghe Comanici Committed by Commit Bot

Fix misleading comment in OmniboxViewViews::OnTabChanged.

The comment refers to code in Browser::ActiveTabChanged, not
BrowserView::OnTabChanged. See code block below

https://cs.chromium.org/chromium/src/chrome/browser/ui/browser.cc?type=cs&q=Browser+ActiveTabChanged&sq=package:chromium&l=1064-1067

This is particularly misleading as one might try to find
the reference in BrowserView::OnActiveTabChanged, which has no
direct reference to the comment in OmniboxViewViews::OnTabChanged.

Change-Id: I71e79e3fe6e874b569e9d4b6da122852eccd3d37
Reviewed-on: https://chromium-review.googlesource.com/767367
Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516314}
parent badd7614
......@@ -197,8 +197,8 @@ void OmniboxViewViews::OnTabChanged(const content::WebContents* web_contents) {
if (state) {
// This assumes that the omnibox has already been focused or blurred as
// appropriate; otherwise, a subsequent OnFocus() or OnBlur() call could
// goof up the selection. See comments at the end of
// BrowserView::ActiveTabChanged().
// goof up the selection. See comments on OnActiveTabChanged() call in
// Browser::ActiveTabChanged().
SelectRange(state->selection);
saved_selection_for_focus_change_ = state->saved_selection_for_focus_change;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment