Commit 4b56905d authored by thomasanderson's avatar thomasanderson Committed by Commit bot

Presubmit: Warn about using XSelectInput

New code running in the browser process should always use
ui::XScopedEventSelector instead of XSelectInput.

BUG=634084

Review-Url: https://codereview.chromium.org/2316373003
Cr-Commit-Position: refs/heads/master@{#418653}
parent 02b71da7
...@@ -163,6 +163,21 @@ _BANNED_CPP_FUNCTIONS = ( ...@@ -163,6 +163,21 @@ _BANNED_CPP_FUNCTIONS = (
False, False,
(), (),
), ),
(
r'XSelectInput|CWEventMask|XCB_CW_EVENT_MASK',
(
'Chrome clients wishing to select events on X windows should use',
'ui::XScopedEventSelector. It is safe to ignore this warning only if',
'you are selecting events from the GPU process, or if you are using',
'an XDisplay other than gfx::GetXDisplay().',
),
True,
(
r"^ui[\\\/]gl[\\\/].*\.cc$",
r"^media[\\\/]gpu[\\\/].*\.cc$",
r"^gpu[\\\/].*\.cc$",
),
),
( (
'ScopedAllowIO', 'ScopedAllowIO',
( (
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment