Commit 4b59436d authored by Eugene But's avatar Eugene But Committed by Chromium LUCI CQ

[ios] Cleanup RemoveProtectionFromPrefFile flag

The experiment did not help with reducing UTEs/XTEs

Bug: None
Change-Id: I4cbb330138e8fc49e13a1dcf0d9787eb1b1946c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613648
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: default avatarOlivier Robin <olivierrobin@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842184}
parent 841521b1
...@@ -79,12 +79,6 @@ ...@@ -79,12 +79,6 @@
namespace { namespace {
// If enabled local state file will have NSURLFileProtectionNone protection
// level set for NSURLFileProtectionKey key. The purpose of this feature is to
// understand if file protection interferes with "clean exit beacon" pref.
const base::Feature kRemoveProtectionFromPrefFile{
"RemoveProtectionFromPrefFile", base::FEATURE_DISABLED_BY_DEFAULT};
// Sets |level| value for NSURLFileProtectionKey key for the URL with given // Sets |level| value for NSURLFileProtectionKey key for the URL with given
// |local_state_path|. // |local_state_path|.
void SetProtectionLevel(const base::FilePath& file_path, id level) { void SetProtectionLevel(const base::FilePath& file_path, id level) {
...@@ -213,15 +207,11 @@ void IOSChromeMainParts::PreCreateThreads() { ...@@ -213,15 +207,11 @@ void IOSChromeMainParts::PreCreateThreads() {
metrics::EnableExpiryChecker(::kExpiredHistogramsHashes, metrics::EnableExpiryChecker(::kExpiredHistogramsHashes,
::kNumExpiredHistograms); ::kNumExpiredHistograms);
// TODO(crbug.com/1164533): Remove code below some time after February 2021.
NSString* const kRemoveProtectionFromPrefFileKey = NSString* const kRemoveProtectionFromPrefFileKey =
@"RemoveProtectionFromPrefKey"; @"RemoveProtectionFromPrefKey";
if (base::FeatureList::IsEnabled(kRemoveProtectionFromPrefFile)) { if ([NSUserDefaults.standardUserDefaults
SetProtectionLevel(local_state_path, NSURLFileProtectionNone); boolForKey:kRemoveProtectionFromPrefFileKey]) {
[NSUserDefaults.standardUserDefaults
setBool:YES
forKey:kRemoveProtectionFromPrefFileKey];
} else if ([NSUserDefaults.standardUserDefaults
boolForKey:kRemoveProtectionFromPrefFileKey]) {
// Restore default protection level when user is no longer in the // Restore default protection level when user is no longer in the
// experimental group. // experimental group.
SetProtectionLevel(local_state_path, SetProtectionLevel(local_state_path,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment