[Breadcrumbs] Fix NTP URL matching for DidStartNavigation event

NTP url path may contain trailing slash ("//newtab/").

Bug: 1046231
Change-Id: I3fd313c6489d7a78e471affa86089d6a9bcae8de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081239
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746409}

ios/chrome/browser/crash_report/breadcrumbs/breadcrumb_manager_tab_helper.mm

@@ -25,7 +25,8 @@ namespace {
 // Returns true if navigation URL repesents Chrome's New Tab Page.
 bool IsNptUrl(const GURL& url) {
   return url.GetOrigin() == kChromeUINewTabURL ||
-         (url.SchemeIs(url::kAboutScheme) && url.path() == "//newtab");
+         (url.SchemeIs(url::kAboutScheme) &&
+          (url.path() == "//newtab" || url.path() == "//newtab/"));
 }
 }
 

ios/chrome/browser/crash_report/breadcrumbs/breadcrumb_manager_tab_helper_unittest.mm

@@ -146,6 +146,25 @@ TEST_F(BreadcrumbManagerTabHelperTest, AboutNewTabNavigationStart) {
       << events.front();
 }
 
+// Tests metadata for about://newtab/ NTP navigation.
+TEST_F(BreadcrumbManagerTabHelperTest, AboutNewTabNavigationStart2) {
+  BreadcrumbManagerTabHelper::CreateForWebState(&first_web_state_);
+  ASSERT_EQ(0ul, breadcrumb_service_->GetEvents(0).size());
+
+  web::FakeNavigationContext context;
+  context.SetUrl(GURL("about://newtab/"));
+  first_web_state_.OnNavigationStarted(&context);
+  std::list<std::string> events = breadcrumb_service_->GetEvents(0);
+  ASSERT_EQ(1ul, events.size());
+
+  EXPECT_NE(std::string::npos, events.front().find(base::StringPrintf(
+                                   "%s%lld", kBreadcrumbDidStartNavigation,
+                                   context.GetNavigationId())))
+      << events.front();
+  EXPECT_NE(std::string::npos, events.front().find(kBreadcrumbNtpNavigation))
+      << events.front();
+}
+
 // Tests unique ID in DidStartNavigation and DidStartNavigation.
 TEST_F(BreadcrumbManagerTabHelperTest, NavigationUniqueId) {
   BreadcrumbManagerTabHelper::CreateForWebState(&first_web_state_);