Commit 4b5e861b authored by Tim Volodine's avatar Tim Volodine Committed by Commit Bot

Disable failing BookmarkPersonalizedSigninPromoDismissTest tests on Tablets

Failing on Marshmallow Tablet Tester:
testPromoImpressionCountIncrementAfterDisplayingSigninPromo
testPromoNotShownAfterBeingDismissed

BUG=1088730
TBR=twellington@chromium.org

Change-Id: Ib9a8d928ccfe3aa7ed6a6c4cac378858e1cd75ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224223
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: default avatarTim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773757}
parent fd3eb5c6
......@@ -24,6 +24,7 @@ import org.junit.rules.RuleChain;
import org.junit.runner.RunWith;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisableIf;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeTabbedActivity;
import org.chromium.chrome.browser.flags.ChromeSwitches;
......@@ -35,6 +36,7 @@ import org.chromium.chrome.test.util.BookmarkTestRule;
import org.chromium.chrome.test.util.BookmarkTestUtil;
import org.chromium.chrome.test.util.ChromeTabUtils;
import org.chromium.content_public.browser.test.util.TestThreadUtils;
import org.chromium.ui.test.util.UiDisableIf;
/**
* Tests different scenarios when the bookmark personalized signin promo is not shown.
......@@ -75,6 +77,7 @@ public class BookmarkPersonalizedSigninPromoDismissTest {
@Test
@MediumTest
@DisableIf.Device(type = {UiDisableIf.TABLET}) // https://crbug.com/1088730
public void testPromoNotShownAfterBeingDismissed() {
mBookmarkTestRule.showBookmarkManager(mSyncTestRule.getActivity());
onView(withId(R.id.signin_promo_view_container)).check(matches(isDisplayed()));
......@@ -108,6 +111,7 @@ public class BookmarkPersonalizedSigninPromoDismissTest {
@Test
@MediumTest
@DisableIf.Device(type = {UiDisableIf.TABLET}) // https://crbug.com/1088730
public void testPromoImpressionCountIncrementAfterDisplayingSigninPromo() {
assertEquals(0, SigninPromoController.getSigninPromoImpressionsCountBookmarks());
mBookmarkTestRule.showBookmarkManager(mSyncTestRule.getActivity());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment