Commit 4b6faca8 authored by Peng Huang's avatar Peng Huang Committed by Commit Bot

vulkan: enable OOP-R & GPU-R if related args are not specified.

Without OOP-R and GPU-R, there are many vulkan queue submissions per
frame. It is bad for performance. So always enable OOP-R and GPU-R for
vulkan unless related commandline arguments are specified.

Bug: 1087063
Change-Id: I4e370af0353ea793e006f8e0b66287306daf64c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226734
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774786}
parent 17029f77
......@@ -170,6 +170,15 @@ GpuFeatureStatus GetGpuRasterizationFeatureStatus(
if (blacklisted_features.count(GPU_FEATURE_TYPE_GPU_RASTERIZATION))
return kGpuFeatureStatusBlacklisted;
// Enable gpu rasterization for vulkan, unless it is overridden by
// commandline.
if (base::FeatureList::IsEnabled(features::kVulkan) &&
!base::FeatureList::GetInstance()->IsFeatureOverriddenFromCommandLine(
features::kDefaultEnableGpuRasterization.name,
base::FeatureList::OVERRIDE_DISABLE_FEATURE)) {
return kGpuFeatureStatusEnabled;
}
// Gpu Rasterization on platforms that are not fully enabled is controlled by
// a finch experiment.
if (!base::FeatureList::IsEnabled(features::kDefaultEnableGpuRasterization))
......@@ -207,11 +216,14 @@ GpuFeatureStatus GetOopRasterizationFeatureStatus(
else if (gpu_preferences.enable_oop_rasterization)
return kGpuFeatureStatusEnabled;
// TODO(enne): Eventually oop rasterization will replace gpu rasterization,
// and so we will need to address the underlying bugs or turn of GPU
// rasterization for these cases.
if (blacklisted_features.count(GPU_FEATURE_TYPE_OOP_RASTERIZATION))
return kGpuFeatureStatusBlacklisted;
// Enable OOP rasterization for vulkan, unless it is overridden by
// commandline.
if (base::FeatureList::IsEnabled(features::kVulkan) &&
!base::FeatureList::GetInstance()->IsFeatureOverriddenFromCommandLine(
features::kDefaultEnableOopRasterization.name,
base::FeatureList::OVERRIDE_DISABLE_FEATURE)) {
return kGpuFeatureStatusEnabled;
}
// OOP Rasterization on platforms that are not fully enabled is controlled by
// a finch experiment.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment