[iOS][MF] Filter android passwords

Filter android passwords from the manual fallback options.

Bug: 905659, 878388, 845472
Change-Id: Id7f120f0747f3ff01d5239568a427dea97a965a9
Reviewed-on: https://chromium-review.googlesource.com/c/1352149
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611094}
parent 04dc53ea
...@@ -5,6 +5,7 @@ ...@@ -5,6 +5,7 @@
#import "ios/chrome/browser/autofill/manual_fill/passwords_fetcher.h" #import "ios/chrome/browser/autofill/manual_fill/passwords_fetcher.h"
#include "components/autofill/core/common/password_form.h" #include "components/autofill/core/common/password_form.h"
#include "components/password_manager/core/browser/android_affiliation/affiliation_utils.h"
#include "components/password_manager/core/browser/password_list_sorter.h" #include "components/password_manager/core/browser/password_list_sorter.h"
#include "components/password_manager/core/browser/password_store.h" #include "components/password_manager/core/browser/password_store.h"
#include "components/password_manager/core/browser/password_store_consumer.h" #include "components/password_manager/core/browser/password_store_consumer.h"
...@@ -92,10 +93,15 @@ class PasswordStoreObserverBridge ...@@ -92,10 +93,15 @@ class PasswordStoreObserverBridge
- (void)onGetPasswordStoreResults: - (void)onGetPasswordStoreResults:
(std::vector<std::unique_ptr<autofill::PasswordForm>>&)result { (std::vector<std::unique_ptr<autofill::PasswordForm>>&)result {
// For Manual Fallback we filter out the android and the blacklisted
// passwords.
result.erase( result.erase(
std::remove_if(result.begin(), result.end(), std::remove_if(result.begin(), result.end(),
[](std::unique_ptr<autofill::PasswordForm>& form) { [](std::unique_ptr<autofill::PasswordForm>& form) {
return form->blacklisted_by_user; const auto is_android_uri =
password_manager::IsValidAndroidFacetURI(
form->signon_realm);
return form->blacklisted_by_user || is_android_uri;
}), }),
result.end()); result.end());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment