Commit 4b7ef458 authored by Michael Spang's avatar Michael Spang Committed by Commit Bot

Enable print_unsymbolized_stack_traces on Chromecast target builds

Chromecast cross compiled builds are always stripped before being
deployed to the target, so local symbolizion doesn't work there.

Enable print_unsymbolized_stack_traces in this config to ensure traces
are in a consistent format, which should be post-processed with
asan_symbolize.py.

Bug: 1040148

Change-Id: Ib133644336beba363faf0efe7792d8bee62531c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991727Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729569}
parent 645b28ec
......@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("//build/config/chromecast_build.gni")
import("//build/config/compiler/compiler.gni")
declare_args() {
......@@ -10,7 +11,13 @@ declare_args() {
# tools/valgrind/asan/asan_symbolize.py. By piping stderr through this script,
# and also enabling symbol_level = 2, you can get much more detailed stack
# traces with file names and line numbers, even in non-ASAN builds.
print_unsymbolized_stack_traces = is_asan || is_lsan || is_msan || is_tsan
#
# It's useful to enable this by default for builds that will be stripped
# before being run (e.g. chromecast cross-compiled builds); this results in
# more consistent output after processing with asan_symbolize.py.
print_unsymbolized_stack_traces =
is_asan || is_lsan || is_msan || is_tsan ||
(is_chromecast && current_toolchain != host_toolchain)
}
static_library("symbolize") {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment