Commit 4b850ded authored by Hajime Hoshi's avatar Hajime Hoshi Committed by Commit Bot

[page_load_metrics] Rename WebContents{Hidden,Shown} to Page{Hidden,Shown}

Page in back-forward cache can be hidden too, so rename the methods to
avoid confusion.

R=csharrisson@chromium.org
BUG=1001087

Change-Id: I3e2a00ecbaf64275bc5cb46c8ab7662f5ad661cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004367Reviewed-by: default avatarCharlie Harrison <csharrison@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732731}
parent 6ce33c94
...@@ -584,15 +584,15 @@ void MetricsWebContentsObserver::OnVisibilityChanged( ...@@ -584,15 +584,15 @@ void MetricsWebContentsObserver::OnVisibilityChanged(
if (in_foreground_) { if (in_foreground_) {
if (committed_load_) if (committed_load_)
committed_load_->WebContentsShown(); committed_load_->PageShown();
for (const auto& kv : provisional_loads_) { for (const auto& kv : provisional_loads_) {
kv.second->WebContentsShown(); kv.second->PageShown();
} }
} else { } else {
if (committed_load_) if (committed_load_)
committed_load_->WebContentsHidden(); committed_load_->PageHidden();
for (const auto& kv : provisional_loads_) { for (const auto& kv : provisional_loads_) {
kv.second->WebContentsHidden(); kv.second->PageHidden();
} }
} }
} }
......
...@@ -298,7 +298,7 @@ void PageLoadTracker::LogAbortChainHistograms( ...@@ -298,7 +298,7 @@ void PageLoadTracker::LogAbortChainHistograms(
} }
} }
void PageLoadTracker::WebContentsHidden() { void PageLoadTracker::PageHidden() {
// Only log the first time we background in a given page load. // Only log the first time we background in a given page load.
if (!first_background_time_.has_value()) { if (!first_background_time_.has_value()) {
// Make sure we either started in the foreground and haven't been // Make sure we either started in the foreground and haven't been
...@@ -316,7 +316,7 @@ void PageLoadTracker::WebContentsHidden() { ...@@ -316,7 +316,7 @@ void PageLoadTracker::WebContentsHidden() {
metrics_update_dispatcher_.timing()); metrics_update_dispatcher_.timing());
} }
void PageLoadTracker::WebContentsShown() { void PageLoadTracker::PageShown() {
// Only log the first time we foreground in a given page load. // Only log the first time we foreground in a given page load.
if (!first_foreground_time_.has_value()) { if (!first_foreground_time_.has_value()) {
// Make sure we either started in the background and haven't been // Make sure we either started in the background and haven't been
......
...@@ -238,8 +238,8 @@ class PageLoadTracker : public PageLoadMetricsUpdateDispatcher::Client, ...@@ -238,8 +238,8 @@ class PageLoadTracker : public PageLoadMetricsUpdateDispatcher::Client,
content::NavigationHandle* navigation_handle); content::NavigationHandle* navigation_handle);
void FailedProvisionalLoad(content::NavigationHandle* navigation_handle, void FailedProvisionalLoad(content::NavigationHandle* navigation_handle,
base::TimeTicks failed_load_time); base::TimeTicks failed_load_time);
void WebContentsHidden(); void PageHidden();
void WebContentsShown(); void PageShown();
void FrameDeleted(content::RenderFrameHost* rfh); void FrameDeleted(content::RenderFrameHost* rfh);
void OnInputEvent(const blink::WebInputEvent& event); void OnInputEvent(const blink::WebInputEvent& event);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment