Commit 4b93a762 authored by jam's avatar jam Committed by Commit bot

Fix testCrashSymbols with PlzNavigate.

The test was looking for a specific stack trace in the renderer. With PlzNavigate, the stack trace is different. Use a method name that's common to both.

BUG=674730

Review-Url: https://codereview.chromium.org/2581833002
Cr-Commit-Position: refs/heads/master@{#439119}
parent 9d47bb8e
...@@ -36,7 +36,8 @@ class TabStackTraceTest(tab_test_case.TabTestCase): ...@@ -36,7 +36,8 @@ class TabStackTraceTest(tab_test_case.TabTestCase):
def testCrashMinimalSymbols(self): def testCrashMinimalSymbols(self):
with self.assertRaises(exceptions.DevtoolsTargetCrashException) as c: with self.assertRaises(exceptions.DevtoolsTargetCrashException) as c:
self._tab.Navigate('chrome://crash', timeout=5) self._tab.Navigate('chrome://crash', timeout=5)
self.assertIn('OnNavigate', '\n'.join(c.exception.stack_trace)) self.assertIn('PrepareRenderViewForNavigation',
'\n'.join(c.exception.stack_trace))
# The breakpad file specific test only apply to platforms which use the # The breakpad file specific test only apply to platforms which use the
# breakpad symbol format. This also must be tested in isolation because it can # breakpad symbol format. This also must be tested in isolation because it can
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment