Commit 4b965235 authored by Noel Gordon's avatar Noel Gordon Committed by Commit Bot

Test FilesApp QuickView [open] attribute

FileApp QuickView has an [open] attribute, present when it (QuickView)
is open, and removed when it's not open. Verify the attribute appears,
and disappears, for all quick_view.js tests.

No change in behavior, no new tests.

Bug: 891150
Change-Id: If90ae81cd60cd350497dece3896173f432571ccc
Reviewed-on: https://chromium-review.googlesource.com/1256465Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595732}
parent 57796c78
...@@ -37,7 +37,7 @@ function openQuickViewSteps(appId, name) { ...@@ -37,7 +37,7 @@ function openQuickViewSteps(appId, name) {
function(result) { function(result) {
chrome.test.assertTrue(!!result, 'fakeKeyDown failed'); chrome.test.assertTrue(!!result, 'fakeKeyDown failed');
repeatUntil(function() { repeatUntil(function() {
const elements = ['#quick-view', '#dialog']; const elements = ['#quick-view', '#dialog[open]'];
return remoteCall return remoteCall
.callRemoteTestUtil( .callRemoteTestUtil(
'deepQueryAllElements', appId, [elements, ['display']]) 'deepQueryAllElements', appId, [elements, ['display']])
...@@ -75,7 +75,7 @@ function closeQuickViewSteps(appId) { ...@@ -75,7 +75,7 @@ function closeQuickViewSteps(appId) {
function(result) { function(result) {
chrome.test.assertTrue(!!result, 'fakeMouseClick failed'); chrome.test.assertTrue(!!result, 'fakeMouseClick failed');
repeatUntil(function() { repeatUntil(function() {
const elements = ['#quick-view', '#dialog']; const elements = ['#quick-view', '#dialog:not([open])'];
return remoteCall return remoteCall
.callRemoteTestUtil( .callRemoteTestUtil(
'deepQueryAllElements', appId, [elements, ['display']]) 'deepQueryAllElements', appId, [elements, ['display']])
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment