drive: Do not rely on argument-dependent lookup when calling MD5DigestToBase16().
Looks like C++ compiler is able to figure out that this function is on base namespace by deducing this from the dependent type base::MD5Digest. For more reference on ADL: http://en.wikipedia.org/wiki/Argument-dependent_name_lookup http://stackoverflow.com/questions/8111677/what-is-argument-dependent-lookup-aka-adl-or-koenig-lookup I found this while doing https://codereview.chromium.org/1099453002/. The error is like the following: ../../chrome/browser/drive/drive_api_util.cc:171:10: error: use of undeclared identifier 'MD5DigestToBase16'; did you mean 'base::MD5DigestToBase16'? return MD5DigestToBase16(digest); ^~~~~~~~~~~~~~~~~ base::MD5DigestToBase16 Log: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/81070/steps/compile/logs/stdio BUG=None R=hashimoto@chromium.org Review URL: https://codereview.chromium.org/1088593005 Cr-Commit-Position: refs/heads/master@{#326949}
Showing
Please register or sign in to comment