Commit 4c0b729f authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in...

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/chrome_service_worker_browsertest.cc.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=nhiroki@chromium.org

Bug: 925652
Change-Id: I4afbb4857597507efe889213423b677deec180ac
Reviewed-on: https://chromium-review.googlesource.com/c/1438285
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626429}
parent c05f055f
...@@ -983,10 +983,10 @@ IN_PROC_BROWSER_TEST_P(ChromeServiceWorkerNavigationPreloadTest, ...@@ -983,10 +983,10 @@ IN_PROC_BROWSER_TEST_P(ChromeServiceWorkerNavigationPreloadTest,
EXPECT_FALSE(HasHeader(received_request(), "Cookie")); EXPECT_FALSE(HasHeader(received_request(), "Cookie"));
} }
INSTANTIATE_TEST_CASE_P(/* no prefix */, INSTANTIATE_TEST_SUITE_P(/* no prefix */,
ChromeServiceWorkerNavigationPreloadTest, ChromeServiceWorkerNavigationPreloadTest,
::testing::Values(ServicifiedFeatures::kNone, ::testing::Values(ServicifiedFeatures::kNone,
ServicifiedFeatures::kServiceWorker, ServicifiedFeatures::kServiceWorker,
ServicifiedFeatures::kNetwork)); ServicifiedFeatures::kNetwork));
} // namespace chrome_service_worker_browser_test } // namespace chrome_service_worker_browser_test
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment