Commit 4c18f0ba authored by liberato@chromium.org's avatar liberato@chromium.org Committed by Commit Bot

Disabled six omnibox-related flaky tests.

InMemoryURLIndexTest.AddNewRows
InMemoryURLIndexTypesTest.OffsetsAndTermMatches
InMemoryURLIndexTest.Retrieval
KeywordProviderTest.URL
InMemoryURLIndexTest.CacheSaveRestore
OmniboxEditModelTest.InlineAutocompleteText

Bug: 1009588
Change-Id: Ia3e749b64e5618bee25cac2874d4ba5e7ece1d45
TBR: jdonnelly@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830285Reviewed-by: default avatarFrank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701273}
parent 16f26300
...@@ -141,7 +141,7 @@ TEST_F(InMemoryURLIndexTypesTest, StaticFunctions) { ...@@ -141,7 +141,7 @@ TEST_F(InMemoryURLIndexTypesTest, StaticFunctions) {
EXPECT_EQ(expected_offsets[i], matches_g[i].offset); EXPECT_EQ(expected_offsets[i], matches_g[i].offset);
} }
TEST_F(InMemoryURLIndexTypesTest, OffsetsAndTermMatches) { TEST_F(InMemoryURLIndexTypesTest, DISABLED_OffsetsAndTermMatches) {
// Test OffsetsFromTermMatches // Test OffsetsFromTermMatches
TermMatches matches_a; TermMatches matches_a;
matches_a.push_back(TermMatch(1, 1, 2)); matches_a.push_back(TermMatch(1, 1, 2));
......
...@@ -488,7 +488,7 @@ TEST_F(InMemoryURLIndexTest, HiddenURLRowsAreIgnored) { ...@@ -488,7 +488,7 @@ TEST_F(InMemoryURLIndexTest, HiddenURLRowsAreIgnored) {
.size()); .size());
} }
TEST_F(InMemoryURLIndexTest, Retrieval) { TEST_F(InMemoryURLIndexTest, DISABLED_Retrieval) {
// See if a very specific term gives a single result. // See if a very specific term gives a single result.
ScoredHistoryMatches matches = url_index_->HistoryItemsForTerms( ScoredHistoryMatches matches = url_index_->HistoryItemsForTerms(
ASCIIToUTF16("DrudgeReport"), base::string16::npos, kProviderMaxMatches); ASCIIToUTF16("DrudgeReport"), base::string16::npos, kProviderMaxMatches);
...@@ -956,7 +956,7 @@ TEST_F(InMemoryURLIndexTest, TypedCharacterCaching) { ...@@ -956,7 +956,7 @@ TEST_F(InMemoryURLIndexTest, TypedCharacterCaching) {
CheckTerm(cache, ASCIIToUTF16("rec")); CheckTerm(cache, ASCIIToUTF16("rec"));
} }
TEST_F(InMemoryURLIndexTest, AddNewRows) { TEST_F(InMemoryURLIndexTest, DISABLED_AddNewRows) {
// Verify that the row we're going to add does not already exist. // Verify that the row we're going to add does not already exist.
history::URLID new_row_id = 87654321; history::URLID new_row_id = 87654321;
// Newly created history::URLRows get a last_visit time of 'right now' so it // Newly created history::URLRows get a last_visit time of 'right now' so it
...@@ -1158,7 +1158,7 @@ TEST_F(InMemoryURLIndexTest, ReadVisitsFromHistory) { ...@@ -1158,7 +1158,7 @@ TEST_F(InMemoryURLIndexTest, ReadVisitsFromHistory) {
} }
} }
TEST_F(InMemoryURLIndexTest, CacheSaveRestore) { TEST_F(InMemoryURLIndexTest, DISABLED_CacheSaveRestore) {
base::ScopedTempDir temp_directory; base::ScopedTempDir temp_directory;
ASSERT_TRUE(temp_directory.CreateUniqueTempDir()); ASSERT_TRUE(temp_directory.CreateUniqueTempDir());
set_history_dir(temp_directory.GetPath()); set_history_dir(temp_directory.GetPath());
......
...@@ -367,7 +367,7 @@ TEST_F(KeywordProviderTest, IgnoreRegistryForScoring) { ...@@ -367,7 +367,7 @@ TEST_F(KeywordProviderTest, IgnoreRegistryForScoring) {
&AutocompleteMatch::fill_into_edit); &AutocompleteMatch::fill_into_edit);
} }
TEST_F(KeywordProviderTest, URL) { TEST_F(KeywordProviderTest, DISABLED_URL) {
const MatchType<GURL> kEmptyMatch = { GURL(), false }; const MatchType<GURL> kEmptyMatch = { GURL(), false };
TestData<GURL> url_cases[] = { TestData<GURL> url_cases[] = {
// No query input -> empty destination URL. // No query input -> empty destination URL.
......
...@@ -223,7 +223,7 @@ TEST_F(OmniboxEditModelTest, AdjustTextForCopyQueryInOmnibox) { ...@@ -223,7 +223,7 @@ TEST_F(OmniboxEditModelTest, AdjustTextForCopyQueryInOmnibox) {
} }
} }
TEST_F(OmniboxEditModelTest, InlineAutocompleteText) { TEST_F(OmniboxEditModelTest, DISABLED_InlineAutocompleteText) {
// Test if the model updates the inline autocomplete text in the view. // Test if the model updates the inline autocomplete text in the view.
EXPECT_EQ(base::string16(), view()->inline_autocomplete_text()); EXPECT_EQ(base::string16(), view()->inline_autocomplete_text());
model()->SetUserText(base::ASCIIToUTF16("he")); model()->SetUserText(base::ASCIIToUTF16("he"));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment