Commit 4c2c6e8c authored by Yi Xu's avatar Yi Xu Committed by Commit Bot

Fixing nits in canvas-perf

Since Math.random() in python generates a random number in range [0,1),
we need to use rand(256) to generate number [0, 255]. Update all calls
in canvas perftest to call rand(256).

Bug:1087019

Change-Id: I75ded3269cf652d7d352e32eefbfeddb999583b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216736
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: default avatarJuanmi Huertas <juanmihd@chromium.org>
Reviewed-by: default avatarFernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#772294}
parent 55e52ff5
...@@ -26,7 +26,7 @@ function rand(range) { ...@@ -26,7 +26,7 @@ function rand(range) {
} }
function randomColor() { function randomColor() {
return "rgba(" + rand(255) + "," + rand(255) + "," + rand(255) + "," + rand(255) + ")"; return "rgba(" + rand(256) + "," + rand(256) + "," + rand(256) + "," + rand(256) + ")";
} }
function makeAndFillCanvasWithRandomColor(i) { function makeAndFillCanvasWithRandomColor(i) {
......
...@@ -25,7 +25,7 @@ function rand(range) { ...@@ -25,7 +25,7 @@ function rand(range) {
} }
function fillCanvas(ctx2d, canvas2d) { function fillCanvas(ctx2d, canvas2d) {
ctx2d.fillStyle = "rgba(" + rand(255) + "," + rand(255) + "," + rand(255) + "," + rand(255) + ")"; ctx2d.fillStyle = "rgba(" + rand(256) + "," + rand(256) + "," + rand(256) + "," + rand(256) + ")";
ctx2d.fillRect(0, 0, canvas2d.width, canvas2d.height); ctx2d.fillRect(0, 0, canvas2d.width, canvas2d.height);
} }
...@@ -37,7 +37,7 @@ function doRun() { ...@@ -37,7 +37,7 @@ function doRun() {
function ensureComplete() { function ensureComplete() {
// Using destCanvas2D as a source image is just to flush out the content when // Using destCanvas2D as a source image is just to flush out the content when
// accelerated 2D canvas is in use. // accelerated 2D canvas is in use.
dummyCtx2D.drawImage(destCanvas2D, 0, 0, 1, 1, 0, 0, 1, 1); dummyCtx2D.drawImage(destCanvas2D, 0, 0, 1, 1, 0, 0, 1, 1);
} }
......
...@@ -10,7 +10,7 @@ var destCanvas2D = document.createElement("canvas"); ...@@ -10,7 +10,7 @@ var destCanvas2D = document.createElement("canvas");
var destCtx2D = destCanvas2D.getContext("2d"); var destCtx2D = destCanvas2D.getContext("2d");
var dummyCanvas2D = document.createElement("canvas"); var dummyCanvas2D = document.createElement("canvas");
var dummyCtx2D = dummyCanvas2D.getContext("2d"); var dummyCtx2D = dummyCanvas2D.getContext("2d");
function setSize(sourceWidth, sourceHeight, destWidth, destHeight) { function setSize(sourceWidth, sourceHeight, destWidth, destHeight) {
sourceCanvas2D.width = sourceWidth; sourceCanvas2D.width = sourceWidth;
sourceCanvas2D.height = sourceHeight; sourceCanvas2D.height = sourceHeight;
...@@ -25,7 +25,7 @@ function rand(range) { ...@@ -25,7 +25,7 @@ function rand(range) {
} }
function fillCanvas(ctx2d, canvas2d) { function fillCanvas(ctx2d, canvas2d) {
ctx2d.fillStyle = "rgba(" + rand(255) + "," + rand(255) + "," + rand(255) + "," + rand(255) + ")"; ctx2d.fillStyle = "rgba(" + rand(256) + "," + rand(256) + "," + rand(256) + "," + rand(256) + ")";
ctx2d.fillRect(0, 0, canvas2d.width, canvas2d.height); ctx2d.fillRect(0, 0, canvas2d.width, canvas2d.height);
} }
...@@ -36,7 +36,7 @@ function doRun() { ...@@ -36,7 +36,7 @@ function doRun() {
function ensureComplete() { function ensureComplete() {
// Using destCanvas2D as a source image is just to flush out the content when // Using destCanvas2D as a source image is just to flush out the content when
// accelerated 2D canvas is in use. // accelerated 2D canvas is in use.
dummyCtx2D.drawImage(destCanvas2D, 0, 0, 1, 1, 0, 0, 1, 1); dummyCtx2D.drawImage(destCanvas2D, 0, 0, 1, 1, 0, 0, 1, 1);
} }
......
...@@ -10,7 +10,7 @@ var destCanvas2D = document.createElement("canvas"); ...@@ -10,7 +10,7 @@ var destCanvas2D = document.createElement("canvas");
var destCtx2D = destCanvas2D.getContext("2d"); var destCtx2D = destCanvas2D.getContext("2d");
var dummyCanvas2D = document.createElement("canvas"); var dummyCanvas2D = document.createElement("canvas");
var dummyCtx2D = dummyCanvas2D.getContext("2d"); var dummyCtx2D = dummyCanvas2D.getContext("2d");
function setSize(sourceWidth, sourceHeight, destWidth, destHeight) { function setSize(sourceWidth, sourceHeight, destWidth, destHeight) {
sourceCanvas2D.width = sourceWidth; sourceCanvas2D.width = sourceWidth;
sourceCanvas2D.height = sourceHeight; sourceCanvas2D.height = sourceHeight;
...@@ -25,7 +25,7 @@ function rand(range) { ...@@ -25,7 +25,7 @@ function rand(range) {
} }
function fillCanvas(ctx2d, canvas2d) { function fillCanvas(ctx2d, canvas2d) {
ctx2d.fillStyle = "rgba(" + rand(255) + "," + rand(255) + "," + rand(255) + "," + rand(255) + ")"; ctx2d.fillStyle = "rgba(" + rand(256) + "," + rand(256) + "," + rand(256) + "," + rand(256) + ")";
ctx2d.fillRect(0, 0, canvas2d.width, canvas2d.height); ctx2d.fillRect(0, 0, canvas2d.width, canvas2d.height);
} }
...@@ -36,7 +36,7 @@ function doRun() { ...@@ -36,7 +36,7 @@ function doRun() {
function ensureComplete() { function ensureComplete() {
// Using destCanvas2D as a source image is just to flush out the content when // Using destCanvas2D as a source image is just to flush out the content when
// accelerated 2D canvas is in use. // accelerated 2D canvas is in use.
dummyCtx2D.drawImage(destCanvas2D, 0, 0, 1, 1, 0, 0, 1, 1); dummyCtx2D.drawImage(destCanvas2D, 0, 0, 1, 1, 0, 0, 1, 1);
} }
......
...@@ -17,7 +17,7 @@ function rand(range) { ...@@ -17,7 +17,7 @@ function rand(range) {
} }
function fillCanvas(ctx2d, canvas2d) { function fillCanvas(ctx2d, canvas2d) {
ctx2d.fillStyle = "rgba(" + rand(255) + "," + rand(255) + "," + rand(255) + "," + rand(255) + ")"; ctx2d.fillStyle = "rgba(" + rand(256) + "," + rand(256) + "," + rand(256) + "," + rand(256) + ")";
ctx2d.fillRect(0, 0, canvas2d.width, canvas2d.height); ctx2d.fillRect(0, 0, canvas2d.width, canvas2d.height);
} }
......
...@@ -25,7 +25,7 @@ function rand(range) { ...@@ -25,7 +25,7 @@ function rand(range) {
} }
function fillCanvas(ctx2d, canvas2d) { function fillCanvas(ctx2d, canvas2d) {
ctx2d.fillStyle = "rgba(" + rand(255) + "," + rand(255) + "," + rand(255) + "," + rand(255) + ")"; ctx2d.fillStyle = "rgba(" + rand(256) + "," + rand(256) + "," + rand(256) + "," + rand(256) + ")";
ctx2d.fillRect(0, 0, canvas2d.width, canvas2d.height); ctx2d.fillRect(0, 0, canvas2d.width, canvas2d.height);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment