Commit 4c41351d authored by Ramin Halavati's avatar Ramin Halavati Committed by Commit Bot

Add clang tool switch to traffic annotation auditor.

A switch is added to clang tool calls from traffic annotation auditor,
to ignore constant comparisons.
Some tests compare constants to prevent future regressions, but clang
sees these as unnecessary comparisons and issues error.

Bug: 690323
Change-Id: Iaa194641f2d6a8cd66ae61f514703bccc28967da
Reviewed-on: https://chromium-review.googlesource.com/958518
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: default avatarMartin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543045}
parent 9e0628f1
......@@ -161,7 +161,8 @@ bool TrafficAnnotationAuditor::RunClangTool(
"--tool-path=%s "
"--tool-arg=--extra-arg=-resource-dir=%s "
"--tool-arg=--extra-arg=-Wno-comment "
"--tool-arg=--extra-arg=-Wno-tautological-unsigned-enum-zero-compare ",
"--tool-arg=--extra-arg=-Wno-tautological-unsigned-enum-zero-compare "
"--tool-arg=--extra-arg=-Wno-tautological-constant-compare ",
build_path_.MaybeAsASCII().c_str(),
base::MakeAbsoluteFilePath(clang_tool_path_).MaybeAsASCII().c_str(),
base::MakeAbsoluteFilePath(GetClangLibraryPath()).MaybeAsASCII().c_str());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment