Commit 4c4757b0 authored by Maks Orlovich's avatar Maks Orlovich Committed by Commit Bot

S13n: Use base::File in FileNetLogObserver observer rather than FILE*

Once NetLog moves to NetworkService, it'll be desirable to have the
output files used for netlogs passed in from browser process, since
sandboxing of network service process probably will limit where it
can write on disk.

base::File (mapped as mojo_base.mojom.File) is the preferred way of transferring files per
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/security/mojo.md#Use-structured-types

This doesn't address actually passing in the file or configuring a
separate in-progress directory for the bounded mode (assuming the network
service will have some temp dir it can write to); that would be the next steps.

Bug: 767450
Change-Id: I814d2fdf6d95016e32d08902038fc84b391411b8
Reviewed-on: https://chromium-review.googlesource.com/1005425
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: default avatarEric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550181}
parent 1fa235b6
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment