Remove PopupWindow usage in TabSelectionEditor

Using PopupWindow as a container has shown some disadvantages, and it
is listed in https://docs.google.com/document/d/1z49-ehX2VzoY_KcMUOSDi3FU7NzqLlrQocD_M-bPZ1A/edit?usp=sharing.

In addition, crrev.com/c/2399314 has also shown the difficulties of
supporting accessibility with the focusable PopupWindow.

This CL removes the PopupWindow usage in TabSelectionEditor by allowing
TabSelectionEditorLayout attaches itself to the parent view when
TabSelectionEditorController#show is called, and removes itself from
the parent view when TabSelectionEditorController#hide is called.

Bug: 1133014, 1124919
Change-Id: Ic53efddd9de1c22d02753c3f40df2769a5603495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438769Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812559}

chrome/android/features/tab_ui/java/res/layout/tab_selection_editor_layout.xml

@@ -9,4 +9,6 @@
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:background="@color/default_bg_color"
+    android:focusable="true"
+    android:focusableInTouchMode="true"
     android:contentDescription="@string/accessibility_tab_selection_editor"/>
\ No newline at end of file

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogCoordinator.java

@@ -107,7 +107,8 @@ public class TabGridDialogCoordinator implements TabGridDialogMediator.DialogCon
             int mode = SysUtils.isLowEndDevice() ? TabListCoordinator.TabListMode.LIST
                                                  : TabListCoordinator.TabListMode.GRID;
             mTabSelectionEditorCoordinator = new TabSelectionEditorCoordinator(context,
-                    mContainerView, tabModelSelector, tabContentManager, mDialogView, mode);
+                    mDialogView.findViewById(R.id.dialog_container_view), tabModelSelector,
+                    tabContentManager, mode);
 
             controller = mTabSelectionEditorCoordinator.getController();
         } else {

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogView.java

@@ -27,7 +27,6 @@ import android.widget.RelativeLayout;
 import android.widget.TextView;
 
 import androidx.annotation.IntDef;
-import androidx.annotation.NonNull;
 import androidx.annotation.VisibleForTesting;
 import androidx.core.content.ContextCompat;
 import androidx.core.graphics.drawable.DrawableCompat;
@@ -51,8 +50,7 @@ import java.util.Map;
 /**
  * Parent for TabGridDialog component.
  */
-public class TabGridDialogView extends FrameLayout
-        implements TabSelectionEditorMediator.TabSelectionEditorPositionProvider {
+public class TabGridDialogView extends FrameLayout {
     private static final int DIALOG_ANIMATION_DURATION = 300;
     private static final int DIALOG_ALPHA_ANIMATION_DURATION = 150;
     private static final int CARD_FADE_ANIMATION_DURATION = 50;
@@ -713,20 +711,6 @@ public class TabGridDialogView extends FrameLayout
         mHideDialogAnimation.start();
     }
 
-    /**
-     * {@link TabSelectionEditorMediator.TabSelectionEditorPositionProvider} implementation.
-     * Returns a {@link Rect} that indicates the current position of dialog.
-     */
-    @Override
-    @NonNull
-    public Rect getSelectionEditorPositionRect() {
-        // Get the status bar height as offset.
-        Rect parentRect = new Rect();
-        mParent.getGlobalVisibleRect(parentRect);
-        return new Rect(mSideMargin, mTopMargin + parentRect.top, mParentWidth - mSideMargin,
-                mParentHeight - mTopMargin + parentRect.top);
-    }
-
     /**
      * Update the ungroup bar based on {@code status}.
      *

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSelectionEditorCoordinator.java

@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.tasks.tab_management;
 
 import static org.chromium.chrome.browser.tasks.tab_management.TabListModel.CardProperties.CARD_TYPE;
 import static org.chromium.chrome.browser.tasks.tab_management.TabListModel.CardProperties.ModelType.OTHERS;
+import static org.chromium.chrome.browser.tasks.tab_management.TabSelectionEditorProperties.IS_VISIBLE;
 
 import android.content.Context;
 import android.view.LayoutInflater;
@@ -20,6 +21,7 @@ import org.chromium.base.metrics.RecordUserAction;
 import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.tabmodel.TabModelSelector;
+import org.chromium.chrome.browser.tasks.tab_management.TabListCoordinator.TabListMode;
 import org.chromium.chrome.tab_ui.R;
 import org.chromium.components.browser_ui.widget.selectable_list.SelectionDelegate;
 import org.chromium.ui.modelutil.LayoutViewBuilder;
@@ -109,25 +111,29 @@ class TabSelectionEditorCoordinator {
     private final TabSelectionEditorLayout mTabSelectionEditorLayout;
     private final TabListCoordinator mTabListCoordinator;
     private final SelectionDelegate<Integer> mSelectionDelegate = new SelectionDelegate<>();
-    private final PropertyModel mModel = new PropertyModel(TabSelectionEditorProperties.ALL_KEYS);
+    private final PropertyModel mModel;
     private final PropertyModelChangeProcessor mTabSelectionEditorLayoutChangeProcessor;
     private final TabSelectionEditorMediator mTabSelectionEditorMediator;
 
     public TabSelectionEditorCoordinator(Context context, ViewGroup parentView,
             TabModelSelector tabModelSelector, TabContentManager tabContentManager,
-            @Nullable TabSelectionEditorMediator
-                    .TabSelectionEditorPositionProvider positionProvider,
-            @TabListCoordinator.TabListMode int mode) {
+            @TabListMode int mode) {
         mContext = context;
         mParentView = parentView;
         mTabModelSelector = tabModelSelector;
         assert mode == TabListCoordinator.TabListMode.GRID
                 || mode == TabListCoordinator.TabListMode.LIST;
 
+        mTabSelectionEditorLayout =
+                LayoutInflater.from(context)
+                        .inflate(R.layout.tab_selection_editor_layout, parentView, false)
+                        .findViewById(R.id.selectable_list);
+
         mTabListCoordinator = new TabListCoordinator(mode, context, mTabModelSelector,
                 tabContentManager::getTabThumbnailWithCallback, null, false, null, null,
-                TabProperties.UiType.SELECTABLE, this::getSelectionDelegate, mParentView, false,
-                COMPONENT_NAME);
+                TabProperties.UiType.SELECTABLE, this::getSelectionDelegate,
+                mTabSelectionEditorLayout, false, COMPONENT_NAME);
+
         // Note: The TabSelectionEditorCoordinator is always created after native is initialized.
         assert LibraryLoader.getInstance().isInitialized();
         mTabListCoordinator.initWithNative(null);
@@ -154,18 +160,19 @@ class TabSelectionEditorCoordinator {
                     });
         }
 
-        mTabSelectionEditorLayout = LayoutInflater.from(context)
-                .inflate(R.layout.tab_selection_editor_layout, null)
-                .findViewById(R.id.selectable_list);
         mTabSelectionEditorLayout.initialize(mParentView, mTabListCoordinator.getContainerView(),
                 mTabListCoordinator.getContainerView().getAdapter(), mSelectionDelegate);
         mSelectionDelegate.setSelectionModeEnabledForZeroItems(true);
 
+        mModel = new PropertyModel.Builder(TabSelectionEditorProperties.ALL_KEYS)
+                         .with(IS_VISIBLE, false)
+                         .build();
+
         mTabSelectionEditorLayoutChangeProcessor = PropertyModelChangeProcessor.create(
-                mModel, mTabSelectionEditorLayout, TabSelectionEditorLayoutBinder::bind);
+                mModel, mTabSelectionEditorLayout, TabSelectionEditorLayoutBinder::bind, false);
 
-        mTabSelectionEditorMediator = new TabSelectionEditorMediator(mContext, mTabModelSelector,
-                this::resetWithListOfTabs, mModel, mSelectionDelegate, positionProvider);
+        mTabSelectionEditorMediator = new TabSelectionEditorMediator(
+                mContext, mTabModelSelector, this::resetWithListOfTabs, mModel, mSelectionDelegate);
     }
 
     /**

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSelectionEditorLayout.java

@@ -5,65 +5,48 @@
 package org.chromium.chrome.browser.tasks.tab_management;
 
 import android.content.Context;
-import android.graphics.Rect;
 import android.util.AttributeSet;
-import android.view.Gravity;
 import android.view.View;
 import android.view.ViewGroup;
-import android.view.ViewTreeObserver;
-import android.view.accessibility.AccessibilityEvent;
 import android.widget.PopupWindow;
 
-import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
-import androidx.annotation.VisibleForTesting;
 import androidx.recyclerview.widget.RecyclerView;
 
 import org.chromium.chrome.tab_ui.R;
 import org.chromium.components.browser_ui.widget.selectable_list.SelectableListLayout;
 import org.chromium.components.browser_ui.widget.selectable_list.SelectionDelegate;
 
+import java.util.HashMap;
+import java.util.Map;
+
 /**
  * This class is used to show the {@link SelectableListLayout} in a {@link PopupWindow}.
  */
 class TabSelectionEditorLayout extends SelectableListLayout<Integer> {
-    private final PopupWindow mWindow;
     private TabSelectionEditorToolbar mToolbar;
-    private View mParentView;
-    private ViewTreeObserver.OnGlobalLayoutListener mParentLayoutListener;
-    private @Nullable Rect mPositionRect;
+    private ViewGroup mParentView;
     private boolean mIsInitialized;
-    private Runnable mEditorHideController;
+    private boolean mIsShowing;
+
+    private Map<View, Integer> mAccessibilityImportanceMap = new HashMap<>();
 
     // TODO(meiliang): inflates R.layout.tab_selection_editor_layout in
     // TabSelectionEditorCoordinator.
     public TabSelectionEditorLayout(Context context, AttributeSet attrs) {
         super(context, attrs);
-        mWindow = new PopupWindow(
-                this, ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT);
-
-        if (TabUiFeatureUtilities.isLaunchPolishEnabled()) {
-            // TODO(crbug.com/1124919): Remove PopupWindow usage, the focusable PopupWindow messes
-            // up the TalkBack. Focusable PopupWindow always focuses the first item in the content
-            // view and announces the first item twice under Talkback mode.
-            mWindow.setFocusable(true);
-            mWindow.setOnDismissListener(() -> {
-                if (mEditorHideController != null) mEditorHideController.run();
-            });
-        }
     }
 
     /**
      * Initializes the RecyclerView and the toolbar for the layout. Also initializes the selection
      * editor layout provider if there is one.This must be called before calling show/hide.
      *
-     * @param parentView The parent view for the {@link PopupWindow}.
+     * @param parentView The parent view to attach the {@link TabSelectionEditorLayout}.
      * @param recyclerView The recycler view to be shown.
      * @param adapter The adapter that provides views that represent items in the recycler view.
      * @param selectionDelegate The {@link SelectionDelegate} that will inform the toolbar of
      *                            selection changes.
      */
-    void initialize(View parentView, RecyclerView recyclerView, RecyclerView.Adapter adapter,
+    void initialize(ViewGroup parentView, RecyclerView recyclerView, RecyclerView.Adapter adapter,
             SelectionDelegate<Integer> selectionDelegate) {
         mIsInitialized = true;
         initializeRecyclerView(adapter, recyclerView);
@@ -74,35 +57,23 @@ class TabSelectionEditorLayout extends SelectableListLayout<Integer> {
     }
 
     /**
-     * Shows the layout in a {@link PopupWindow}.
+     * Add and shows the layout in the parent view.
      */
     public void show() {
         assert mIsInitialized;
-        if (mPositionRect == null) {
-            mWindow.showAtLocation(mParentView, Gravity.CENTER, 0, 0);
-            if (TabUiFeatureUtilities.isLaunchPolishEnabled()) {
-                // TODO(crbug.com/1124919): The following line forces Talkback to announce the
-                // content description of this view. Remove after PopupWindow usage is removed.
-                sendAccessibilityEvent(AccessibilityEvent.TYPE_ANNOUNCEMENT);
-            }
-            return;
-        }
-        mWindow.setWidth(mPositionRect.width());
-        mWindow.setHeight(mPositionRect.height());
-        mWindow.showAtLocation(
-                mParentView, Gravity.NO_GRAVITY, mPositionRect.left, mPositionRect.top);
-        if (TabUiFeatureUtilities.isLaunchPolishEnabled()) {
-            // TODO(crbug.com/1124919): Remove after PopupWindow usage is removed.
-            sendAccessibilityEvent(AccessibilityEvent.TYPE_ANNOUNCEMENT);
-        }
+        mIsShowing = true;
+        clearBackgroundViewAccessibilityImportance();
+        mParentView.addView(this);
     }
 
     /**
-     * Hides the {@link PopupWindow}.
+     * Remove and hides the layout from parent view.
      */
     public void hide() {
-        assert mIsInitialized;
-        if (mWindow.isShowing()) mWindow.dismiss();
+        assert mIsInitialized && mIsShowing;
+        mIsShowing = false;
+        mParentView.removeView(this);
+        restoreBackgroundViewAccessibilityImportance();
     }
 
     /**
@@ -112,51 +83,40 @@ class TabSelectionEditorLayout extends SelectableListLayout<Integer> {
         return mToolbar;
     }
 
-    /**
-     * Register a {@link ViewTreeObserver.OnGlobalLayoutListener} handling TabSelectionEditor
-     * related changes when parent view global layout changed.
-     */
-    public void registerGlobalLayoutListener(ViewTreeObserver.OnGlobalLayoutListener listener) {
-        if (mParentView == null || listener == null) return;
-        if (mParentLayoutListener != null) {
-            mParentView.getViewTreeObserver().removeOnGlobalLayoutListener(mParentLayoutListener);
-        }
-        mParentLayoutListener = listener;
-        mParentView.getViewTreeObserver().addOnGlobalLayoutListener(listener);
-    }
-
-    /**
-     * Update the {@link Rect} used to show the selection editor. If the editor is currently
-     * showing, update its positioning.
-     * @param rect  The {@link Rect} to update mPositionRect.
-     */
-    public void updateTabSelectionEditorPositionRect(@NonNull Rect rect) {
-        assert rect != null;
-        mPositionRect = rect;
-        if (mWindow.isShowing()) {
-            mWindow.update(rect.left, rect.top, rect.width(), rect.height());
-        }
-    }
-
     /**
      * Destroy any members that needs clean up.
      */
     public void destroy() {
         super.onDestroyed();
+    }
+
+    private void clearBackgroundViewAccessibilityImportance() {
+        assert mAccessibilityImportanceMap.size() == 0 && mParentView.indexOfChild(this) == -1;
 
-        if (mParentView != null && mParentLayoutListener != null) {
-            mParentView.getViewTreeObserver().removeOnGlobalLayoutListener(mParentLayoutListener);
+        for (int i = 0; i < mParentView.getChildCount(); i++) {
+            View view = mParentView.getChildAt(i);
+            mAccessibilityImportanceMap.put(view, view.getImportantForAccessibility());
+            view.setImportantForAccessibility(IMPORTANT_FOR_ACCESSIBILITY_NO_HIDE_DESCENDANTS);
         }
+        mAccessibilityImportanceMap.put(mParentView, mParentView.getImportantForAccessibility());
+        mParentView.setImportantForAccessibility(IMPORTANT_FOR_ACCESSIBILITY_NO);
     }
 
-    @VisibleForTesting
-    Rect getPositionRectForTesting() {
-        return mPositionRect;
-    }
+    private void restoreBackgroundViewAccessibilityImportance() {
+        assert mParentView.indexOfChild(this) == -1;
 
-    void setEditorHideController(Runnable hideController) {
-        if (!TabUiFeatureUtilities.isLaunchPolishEnabled()) return;
+        for (int i = 0; i < mParentView.getChildCount(); i++) {
+            View view = mParentView.getChildAt(i);
 
-        mEditorHideController = hideController;
+            assert mAccessibilityImportanceMap.containsKey(view);
+            Integer importance = mAccessibilityImportanceMap.get(view);
+            view.setImportantForAccessibility(
+                    importance == null ? IMPORTANT_FOR_ACCESSIBILITY_AUTO : importance);
+        }
+        assert mAccessibilityImportanceMap.containsKey(mParentView);
+        Integer importance = mAccessibilityImportanceMap.get(mParentView);
+        mParentView.setImportantForAccessibility(
+                importance == null ? IMPORTANT_FOR_ACCESSIBILITY_AUTO : importance);
+        mAccessibilityImportanceMap.clear();
     }
 }

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSelectionEditorLayoutBinder.java

@@ -4,8 +4,6 @@
 
 package org.chromium.chrome.browser.tasks.tab_management;
 
-import android.graphics.Rect;
-
 import org.chromium.ui.modelutil.PropertyKey;
 import org.chromium.ui.modelutil.PropertyModel;
 
@@ -51,24 +49,10 @@ public class TabSelectionEditorLayoutBinder {
                 == propertyKey) {
             view.getToolbar().setActionButtonEnablingThreshold(model.get(
                     TabSelectionEditorProperties.TOOLBAR_ACTION_BUTTON_ENABLING_THRESHOLD));
-        } else if (TabSelectionEditorProperties.SELECTION_EDITOR_POSITION_RECT == propertyKey) {
-            Rect positionRect =
-                    model.get(TabSelectionEditorProperties.SELECTION_EDITOR_POSITION_RECT);
-            if (positionRect == null) {
-                return;
-            }
-            view.updateTabSelectionEditorPositionRect(positionRect);
-        } else if (TabSelectionEditorProperties.SELECTION_EDITOR_GLOBAL_LAYOUT_LISTENER
-                == propertyKey) {
-            view.registerGlobalLayoutListener(model.get(
-                    TabSelectionEditorProperties.SELECTION_EDITOR_GLOBAL_LAYOUT_LISTENER));
         } else if (TabSelectionEditorProperties.TOOLBAR_ACTION_BUTTON_DESCRIPTION_RESOURCE_ID
                 == propertyKey) {
             view.getToolbar().setActionButtonDescriptionResourceId(model.get(
                     TabSelectionEditorProperties.TOOLBAR_ACTION_BUTTON_DESCRIPTION_RESOURCE_ID));
-        } else if (TabUiFeatureUtilities.isLaunchPolishEnabled()
-                && TabSelectionEditorProperties.DISMISS_HANDLER == propertyKey) {
-            view.setEditorHideController(model.get(TabSelectionEditorProperties.DISMISS_HANDLER));
         }
     }
 }

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSelectionEditorMediator.java

@@ -6,11 +6,9 @@ package org.chromium.chrome.browser.tasks.tab_management;
 
 import android.content.Context;
 import android.content.res.ColorStateList;
-import android.graphics.Rect;
 import android.view.View;
 
 import androidx.annotation.ColorInt;
-import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.appcompat.content.res.AppCompatResources;
 
@@ -53,19 +51,6 @@ class TabSelectionEditorMediator
         void resetWithListOfTabs(@Nullable List<Tab> tabs, int preSelectedCount);
     }
 
-    /**
-     * An interface to provide the {@link Rect} used to position the selection editor on screen.
-     */
-    public interface TabSelectionEditorPositionProvider {
-        /**
-         * This method fetches the {@link Rect} used to position the selection editor layout.
-         * @return The {@link Rect} indicates where to show the selection editor layout. This Rect
-         * should never be null.
-         */
-        @NonNull
-        Rect getSelectionEditorPositionRect();
-    }
-
     private final Context mContext;
     private final TabModelSelector mTabModelSelector;
     private final ResetHandler mResetHandler;
@@ -73,7 +58,6 @@ class TabSelectionEditorMediator
     private final SelectionDelegate<Integer> mSelectionDelegate;
     private final TabModelSelectorTabModelObserver mTabModelObserver;
     private final TabModelSelectorObserver mTabModelSelectorObserver;
-    private final TabSelectionEditorPositionProvider mPositionProvider;
     private TabSelectionEditorActionProvider mActionProvider;
     private TabSelectionEditorCoordinator.TabSelectionEditorNavigationProvider mNavigationProvider;
 
@@ -101,15 +85,12 @@ class TabSelectionEditorMediator
 
     TabSelectionEditorMediator(Context context, TabModelSelector tabModelSelector,
             ResetHandler resetHandler, PropertyModel model,
-            SelectionDelegate<Integer> selectionDelegate,
-            @Nullable TabSelectionEditorMediator
-                    .TabSelectionEditorPositionProvider positionProvider) {
+            SelectionDelegate<Integer> selectionDelegate) {
         mContext = context;
         mTabModelSelector = tabModelSelector;
         mResetHandler = resetHandler;
         mModel = model;
         mSelectionDelegate = selectionDelegate;
-        mPositionProvider = positionProvider;
 
         mModel.set(
                 TabSelectionEditorProperties.TOOLBAR_NAVIGATION_LISTENER, mNavigationClickListener);
@@ -119,6 +100,7 @@ class TabSelectionEditorMediator
         mTabModelObserver = new TabModelSelectorTabModelObserver(mTabModelSelector) {
             @Override
             public void didAddTab(Tab tab, int type, @TabCreationState int creationState) {
+                if (!mTabModelSelector.isTabStateInitialized()) return;
                 // When tab is added due to multi-window close or moving between multiple windows,
                 // force hiding the selection editor.
                 if (type == TabLaunchType.FROM_RESTORE || type == TabLaunchType.FROM_REPARENTING) {
@@ -170,18 +152,6 @@ class TabSelectionEditorMediator
 
         mNavigationProvider =
                 new TabSelectionEditorCoordinator.TabSelectionEditorNavigationProvider(this);
-
-        if (mPositionProvider != null) {
-            mModel.set(TabSelectionEditorProperties.SELECTION_EDITOR_GLOBAL_LAYOUT_LISTENER,
-                    ()
-                            -> mModel.set(
-                                    TabSelectionEditorProperties.SELECTION_EDITOR_POSITION_RECT,
-                                    mPositionProvider.getSelectionEditorPositionRect()));
-        }
-
-        if (TabUiFeatureUtilities.isLaunchPolishEnabled()) {
-            mModel.set(TabSelectionEditorProperties.DISMISS_HANDLER, this::hide);
-        }
     }
 
     private boolean isEditorVisible() {
@@ -214,10 +184,6 @@ class TabSelectionEditorMediator
 
         mResetHandler.resetWithListOfTabs(tabs, preSelectedTabCount);
 
-        if (mPositionProvider != null) {
-            mModel.set(TabSelectionEditorProperties.SELECTION_EDITOR_POSITION_RECT,
-                    mPositionProvider.getSelectionEditorPositionRect());
-        }
         mModel.set(TabSelectionEditorProperties.IS_VISIBLE, true);
     }
 

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSelectionEditorProperties.java

@@ -5,10 +5,7 @@
 package org.chromium.chrome.browser.tasks.tab_management;
 
 import android.content.res.ColorStateList;
-import android.graphics.Rect;
 import android.view.View;
-import android.view.ViewTreeObserver;
-
 import org.chromium.ui.modelutil.PropertyKey;
 import org.chromium.ui.modelutil.PropertyModel;
 
@@ -47,25 +44,13 @@ public class TabSelectionEditorProperties {
     public static final PropertyModel.WritableIntPropertyKey TOOLBAR_TEXT_APPEARANCE =
             new PropertyModel.WritableIntPropertyKey();
 
-    public static final PropertyModel
-            .WritableObjectPropertyKey<Rect> SELECTION_EDITOR_POSITION_RECT =
-            new PropertyModel.WritableObjectPropertyKey<>();
-
-    public static final PropertyModel.WritableObjectPropertyKey<
-            ViewTreeObserver.OnGlobalLayoutListener> SELECTION_EDITOR_GLOBAL_LAYOUT_LISTENER =
-            new PropertyModel.WritableObjectPropertyKey<>();
-
     public static final PropertyModel
             .WritableIntPropertyKey TOOLBAR_ACTION_BUTTON_DESCRIPTION_RESOURCE_ID =
             new PropertyModel.WritableIntPropertyKey();
 
-    public static final PropertyModel.WritableObjectPropertyKey<Runnable> DISMISS_HANDLER =
-            new PropertyModel.WritableObjectPropertyKey();
-
     public static final PropertyKey[] ALL_KEYS = new PropertyKey[] {IS_VISIBLE,
             TOOLBAR_ACTION_BUTTON_LISTENER, TOOLBAR_ACTION_BUTTON_TEXT,
             TOOLBAR_ACTION_BUTTON_ENABLING_THRESHOLD, TOOLBAR_NAVIGATION_LISTENER, PRIMARY_COLOR,
             TOOLBAR_BACKGROUND_COLOR, TOOLBAR_GROUP_BUTTON_TINT, TOOLBAR_TEXT_APPEARANCE,
-            SELECTION_EDITOR_POSITION_RECT, SELECTION_EDITOR_GLOBAL_LAYOUT_LISTENER,
-            TOOLBAR_ACTION_BUTTON_DESCRIPTION_RESOURCE_ID, DISMISS_HANDLER};
+            TOOLBAR_ACTION_BUTTON_DESCRIPTION_RESOURCE_ID};
 }

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherCoordinator.java

@@ -109,6 +109,7 @@ public class TabSwitcherCoordinator
     private ViewGroup mContainer;
     private TabCreatorManager mTabCreatorManager;
     private boolean mIsInitialized;
+    private final ViewGroup mRootView;
 
     private final MenuOrKeyboardActionController
             .MenuOrKeyboardActionHandler mTabSwitcherMenuActionHandler =
@@ -147,6 +148,7 @@ public class TabSwitcherCoordinator
         mMode = mode;
         mTabModelSelector = tabModelSelector;
         mContainer = container;
+        mRootView = ((ChromeTabbedActivity) context).findViewById(R.id.coordinator);
         mTabCreatorManager = tabCreatorManager;
         mMultiWindowModeStateDispatcher = multiWindowModeStateDispatcher;
 
@@ -213,9 +215,8 @@ public class TabSwitcherCoordinator
 
         if (TabUiFeatureUtilities.isTabGroupsAndroidEnabled()) {
             mTabGridDialogCoordinator = new TabGridDialogCoordinator(context, tabModelSelector,
-                    tabContentManager, tabCreatorManager,
-                    ((ChromeTabbedActivity) context).findViewById(R.id.coordinator), this,
-                    mMediator, this::getTabGridDialogAnimationSourceView, shareDelegateSupplier,
+                    tabContentManager, tabCreatorManager, mRootView, this, mMediator,
+                    this::getTabGridDialogAnimationSourceView, shareDelegateSupplier,
                     scrimCoordinator);
             mMediator.setTabGridDialogController(mTabGridDialogCoordinator.getDialogController());
         } else {
@@ -314,8 +315,8 @@ public class TabSwitcherCoordinator
         int selectionEditorMode = mMode == TabListCoordinator.TabListMode.CAROUSEL
                 ? TabListCoordinator.TabListMode.GRID
                 : mMode;
-        mTabSelectionEditorCoordinator = new TabSelectionEditorCoordinator(context, mContainer,
-                mTabModelSelector, tabContentManager, null, selectionEditorMode);
+        mTabSelectionEditorCoordinator = new TabSelectionEditorCoordinator(
+                context, mRootView, mTabModelSelector, tabContentManager, selectionEditorMode);
         mMediator.initWithNative(mTabSelectionEditorCoordinator.getController());
 
         mTabGroupManualSelectionMode = new TabGroupManualSelectionMode(

chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogTest.java

@@ -27,7 +27,6 @@ import static androidx.test.espresso.matcher.ViewMatchers.withParent;
 import static androidx.test.espresso.matcher.ViewMatchers.withText;
 
 import static org.hamcrest.Matchers.allOf;
-import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.not;
 import static org.hamcrest.core.IsEqual.equalTo;
 import static org.junit.Assert.assertEquals;
@@ -108,6 +107,7 @@ import org.chromium.chrome.test.ChromeJUnit4RunnerDelegate;
 import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
 import org.chromium.chrome.test.util.ChromeRenderTestRule;
 import org.chromium.chrome.test.util.browser.Features;
+import org.chromium.chrome.test.util.browser.Features.EnableFeatures;
 import org.chromium.content_public.browser.test.util.CriteriaHelper;
 import org.chromium.content_public.browser.test.util.TestThreadUtils;
 import org.chromium.ui.KeyboardVisibilityDelegate;
@@ -415,8 +415,13 @@ public class TabGridDialogTest {
 
     @Test
     @MediumTest
-    @Features.EnableFeatures(ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID)
+    // clang-format off
+    @EnableFeatures({ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID,
+        ChromeFeatureList.TAB_GRID_LAYOUT_ANDROID + "<Study"})
+    @CommandLineFlags.Add({"force-fieldtrials=Study/Group",
+        "force-fieldtrial-params=Study.Group:enable_launch_polish/true"})
     public void testSelectionEditorShowHide() throws ExecutionException {
+        // clang-format on
         final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
         createTabs(cta, false, 2);
         enterTabSwitcher(cta);
@@ -532,8 +537,13 @@ public class TabGridDialogTest {
 
     @Test
     @MediumTest
-    @Features.EnableFeatures(ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID)
+    // clang-format off
+    @EnableFeatures({ChromeFeatureList.TAB_GROUPS_CONTINUATION_ANDROID,
+        ChromeFeatureList.TAB_GRID_LAYOUT_ANDROID + "<Study"})
+    @CommandLineFlags.Add({"force-fieldtrials=Study/Group",
+        "force-fieldtrial-params=Study.Group:enable_launch_polish/true"})
     public void testSelectionEditorPosition() {
+        // clang-format on
         final ChromeTabbedActivity cta = mActivityTestRule.getActivity();
         View parentView = cta.getCompositorViewHolder();
         createTabs(cta, false, 3);
@@ -546,22 +556,22 @@ public class TabGridDialogTest {
 
         // Verify the size and position of TabGridDialog in portrait mode.
         openDialogFromTabSwitcherAndVerify(cta, 3, null);
-        checkPopupPosition(cta, true, true);
+        checkPosition(cta, true, true);
 
         // Verify the size and position of TabSelectionEditor in portrait mode.
         openSelectionEditorAndVerify(cta, 3);
-        checkPopupPosition(cta, false, true);
+        checkPosition(cta, false, true);
 
         // Verify the size and position of TabSelectionEditor in landscape mode.
         rotateDeviceToOrientation(cta, Configuration.ORIENTATION_LANDSCAPE);
         CriteriaHelper.pollUiThread(() -> parentView.getHeight() < parentView.getWidth());
-        checkPopupPosition(cta, false, false);
+        checkPosition(cta, false, false);
 
         // Verify the size and position of TabGridDialog in landscape mode.
         mSelectionEditorRobot.actionRobot.clickToolbarNavigationButton();
         mSelectionEditorRobot.resultRobot.verifyTabSelectionEditorIsHidden();
         assertTrue(isDialogShowing(cta));
-        checkPopupPosition(cta, true, false);
+        checkPosition(cta, true, false);
 
         // Verify the positioning in multi-window mode. Adjusting the height of the root view to
         // mock entering/exiting multi-window mode.
@@ -574,17 +584,17 @@ public class TabGridDialogTest {
             params.height = rootViewHeight / 2;
             rootView.setLayoutParams(params);
         });
-        checkPopupPosition(cta, true, true);
+        checkPosition(cta, true, true);
         openSelectionEditorAndVerify(cta, 3);
-        checkPopupPosition(cta, false, true);
+        checkPosition(cta, false, true);
 
         TestThreadUtils.runOnUiThreadBlocking(() -> {
             ViewGroup.LayoutParams params = rootView.getLayoutParams();
             params.height = rootViewHeight;
             rootView.setLayoutParams(params);
         });
-        checkPopupPosition(cta, false, true);
-        checkPopupPosition(cta, true, true);
+        checkPosition(cta, false, true);
+        checkPosition(cta, true, true);
     }
 
     @Test
@@ -1154,8 +1164,7 @@ public class TabGridDialogTest {
                 .verifyAdapterHasItemCount(count);
     }
 
-    private void checkPopupPosition(
-            ChromeTabbedActivity cta, boolean isDialog, boolean isPortrait) {
+    private void checkPosition(ChromeTabbedActivity cta, boolean isDialog, boolean isPortrait) {
         // If isDialog is true, we are checking the position of TabGridDialog; otherwise we are
         // checking the position of TabSelectionEditor.
         int contentViewId = isDialog ? R.id.dialog_container_view : R.id.selectable_list;
@@ -1168,19 +1177,16 @@ public class TabGridDialogTest {
         Rect parentRect = new Rect();
         parentView.getGlobalVisibleRect(parentRect);
 
-        onView(withId(contentViewId))
-                .inRoot(isDialog ? withDecorView(is(cta.getWindow().getDecorView()))
-                                 : withDecorView(not(cta.getWindow().getDecorView())))
-                .check((v, e) -> {
-                    int[] location = new int[2];
-                    v.getLocationOnScreen(location);
-                    // Check the position.
-                    assertEquals(sideMargin, location[0]);
-                    assertEquals(topMargin + parentRect.top, location[1]);
-                    // Check the size.
-                    assertEquals(parentView.getHeight() - 2 * topMargin, v.getHeight());
-                    assertEquals(parentView.getWidth() - 2 * sideMargin, v.getWidth());
-                });
+        onView(isDialog ? withId(contentViewId) : withId(contentViewId)).check((v, e) -> {
+            int[] location = new int[2];
+            v.getLocationOnScreen(location);
+            // Check the position.
+            assertEquals(sideMargin, location[0]);
+            assertEquals(topMargin + parentRect.top, location[1]);
+            // Check the size.
+            assertEquals(parentView.getHeight() - 2 * topMargin, v.getHeight());
+            assertEquals(parentView.getWidth() - 2 * sideMargin, v.getWidth());
+        });
     }
 
     private void editDialogTitle(ChromeTabbedActivity cta, String title) {

chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabSelectionEditorLayoutBinderTest.java

@@ -4,16 +4,13 @@
 
 package org.chromium.chrome.browser.tasks.tab_management;
 
-import static junit.framework.Assert.assertEquals;
 import static junit.framework.Assert.assertFalse;
 import static junit.framework.Assert.assertNotNull;
 import static junit.framework.Assert.assertTrue;
 
 import static org.junit.Assert.assertNull;
 
-import android.graphics.Rect;
 import android.view.ViewGroup;
-import android.view.ViewTreeObserver;
 import android.widget.Button;
 import android.widget.LinearLayout;
 import android.widget.TextView;
@@ -132,32 +129,6 @@ public class TabSelectionEditorLayoutBinderTest extends DummyUiActivityTestCase
         assertFalse(button.isEnabled());
     }
 
-    @Test
-    @SmallTest
-    @UiThreadTest
-    public void testSetPositionRect() {
-        assertNull(mEditorLayoutView.getPositionRectForTesting());
-
-        Rect rect = new Rect();
-        mModel.set(TabSelectionEditorProperties.SELECTION_EDITOR_POSITION_RECT, rect);
-
-        assertEquals(rect, mModel.get(TabSelectionEditorProperties.SELECTION_EDITOR_POSITION_RECT));
-    }
-
-    @Test
-    @SmallTest
-    @UiThreadTest
-    public void testRegisterGlobalLayoutListener() {
-        AtomicBoolean globalLayoutChanged = new AtomicBoolean();
-        globalLayoutChanged.set(false);
-
-        ViewTreeObserver.OnGlobalLayoutListener listener = () -> globalLayoutChanged.set(true);
-        mModel.set(TabSelectionEditorProperties.SELECTION_EDITOR_GLOBAL_LAYOUT_LISTENER, listener);
-        mParentView.getViewTreeObserver().dispatchOnGlobalLayout();
-
-        assertTrue(globalLayoutChanged.get());
-    }
-
     @Test
     @SmallTest
     @UiThreadTest

chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabSelectionEditorTest.java

@@ -4,6 +4,10 @@
 
 package org.chromium.chrome.browser.tasks.tab_management;
 
+import static android.view.View.IMPORTANT_FOR_ACCESSIBILITY_NO;
+import static android.view.View.IMPORTANT_FOR_ACCESSIBILITY_NO_HIDE_DESCENDANTS;
+import static android.view.View.IMPORTANT_FOR_ACCESSIBILITY_YES;
+
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNull;
@@ -42,6 +46,7 @@ import org.chromium.chrome.test.ChromeJUnit4ClassRunner;
 import org.chromium.chrome.test.ChromeTabbedActivityTestRule;
 import org.chromium.chrome.test.util.ChromeRenderTestRule;
 import org.chromium.chrome.test.util.ChromeTabUtils;
+import org.chromium.chrome.test.util.browser.Features;
 import org.chromium.chrome.test.util.browser.Features.DisableFeatures;
 import org.chromium.chrome.test.util.browser.Features.EnableFeatures;
 import org.chromium.content_public.browser.test.util.CriteriaHelper;
@@ -51,7 +56,9 @@ import org.chromium.ui.test.util.UiRestriction;
 import java.io.IOException;
 import java.lang.ref.WeakReference;
 import java.util.ArrayList;
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 
 /**
  * End-to-end test for TabSelectionEditor.
@@ -78,18 +85,18 @@ public class TabSelectionEditorTest {
     private TabSelectionEditorCoordinator mTabSelectionEditorCoordinator;
     private WeakReference<TabSelectionEditorLayout> mRef;
 
+    private ViewGroup mParentView;
+
     @Before
     public void setUp() throws Exception {
         mActivityTestRule.startMainActivityOnBlankPage();
 
         mTabModelSelector = mActivityTestRule.getActivity().getTabModelSelector();
-
+        mParentView = (ViewGroup) mActivityTestRule.getActivity().findViewById(R.id.coordinator);
         TestThreadUtils.runOnUiThreadBlocking(() -> {
             mTabSelectionEditorCoordinator = new TabSelectionEditorCoordinator(
-                    mActivityTestRule.getActivity(),
-                    (ViewGroup) mActivityTestRule.getActivity().getWindow().getDecorView(),
-                    mTabModelSelector, mActivityTestRule.getActivity().getTabContentManager(), null,
-                    getMode());
+                    mActivityTestRule.getActivity(), mParentView, mTabModelSelector,
+                    mActivityTestRule.getActivity().getTabContentManager(), getMode());
 
             mTabSelectionEditorController = mTabSelectionEditorCoordinator.getController();
             mTabSelectionEditorLayout =
@@ -168,7 +175,12 @@ public class TabSelectionEditorTest {
 
     @Test
     @MediumTest
+    // clang-format off
+    @Features.EnableFeatures({ChromeFeatureList.TAB_GRID_LAYOUT_ANDROID + "<Study"})
+    @CommandLineFlags.Add({"force-fieldtrials=Study/Group",
+        "force-fieldtrial-params=Study.Group:enable_launch_polish/true"})
     public void testToolbarNavigationButtonHideTabSelectionEditor() {
+        // clang-format on
         prepareBlankTab(2, false);
         List<Tab> tabs = getTabsInCurrentTabModel();
 
@@ -591,6 +603,60 @@ public class TabSelectionEditorTest {
         mRobot.resultRobot.verifyTabSelectionEditorIsVisible();
     }
 
+    @Test
+    @MediumTest
+    // clang-format off
+    @EnableFeatures({ChromeFeatureList.TAB_GRID_LAYOUT_ANDROID + "<Study"})
+    @CommandLineFlags.Add({"force-fieldtrials=Study/Group",
+        "force-fieldtrial-params=Study.Group:enable_launch_polish/true"})
+    public void testBackgroundViewAccessibilityImportance() {
+        // clang-format on
+        prepareBlankTab(2, false);
+        List<Tab> tabs = getTabsInCurrentTabModel();
+
+        Map<View, Integer> initialValues = getParentViewAccessibilityImportanceMap();
+
+        TestThreadUtils.runOnUiThreadBlocking(() -> { mTabSelectionEditorController.show(tabs); });
+        mRobot.resultRobot.verifyTabSelectionEditorIsVisible();
+        ViewGroup parentView = (ViewGroup) mTabSelectionEditorLayout.getParent();
+        verifyBackgroundViewAccessibilityImportance(parentView, true, initialValues);
+
+        mRobot.actionRobot.clickToolbarNavigationButton();
+        mRobot.resultRobot.verifyTabSelectionEditorIsHidden();
+        verifyBackgroundViewAccessibilityImportance(parentView, false, initialValues);
+    }
+
+    private Map<View, Integer> getParentViewAccessibilityImportanceMap() {
+        Map<View, Integer> map = new HashMap<>();
+
+        for (int i = 0; i < mParentView.getChildCount(); i++) {
+            View view = mParentView.getChildAt(i);
+            map.put(view, view.getImportantForAccessibility());
+        }
+
+        map.put(mParentView, mParentView.getImportantForAccessibility());
+        return map;
+    }
+
+    private void verifyBackgroundViewAccessibilityImportance(ViewGroup parentView,
+            boolean isTabSelectionEditorShowing, Map<View, Integer> initialValues) {
+        assertEquals(isTabSelectionEditorShowing ? IMPORTANT_FOR_ACCESSIBILITY_NO
+                                                 : initialValues.get(parentView).intValue(),
+                parentView.getImportantForAccessibility());
+
+        for (int i = 0; i < parentView.getChildCount(); i++) {
+            View view = parentView.getChildAt(i);
+            int expected = isTabSelectionEditorShowing
+                    ? IMPORTANT_FOR_ACCESSIBILITY_NO_HIDE_DESCENDANTS
+                    : initialValues.get(view).intValue();
+            if (view == mTabSelectionEditorLayout) {
+                expected = IMPORTANT_FOR_ACCESSIBILITY_YES;
+            }
+
+            assertEquals(expected, view.getImportantForAccessibility());
+        }
+    }
+
     private List<Tab> getTabsInCurrentTabModel() {
         List<Tab> tabs = new ArrayList<>();
 

chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabSuggestionMessageCardTest.java

@@ -46,7 +46,7 @@ import org.chromium.ui.test.util.UiRestriction;
 @RunWith(ChromeJUnit4ClassRunner.class)
 // clang-format off
 @Restriction(UiRestriction.RESTRICTION_TYPE_PHONE)
-@Features.EnableFeatures({ChromeFeatureList.TAB_GRID_LAYOUT_ANDROID,
+@Features.EnableFeatures({ChromeFeatureList.TAB_GRID_LAYOUT_ANDROID+"<Study",
         ChromeFeatureList.TAB_GROUPS_ANDROID,
         ChromeFeatureList.CLOSE_TAB_SUGGESTIONS+"<Study"})
 // Disable TAB_TO_GTS_ANIMATION to make it less flaky. When animation is enabled, the suggestion
@@ -57,7 +57,7 @@ import org.chromium.ui.test.util.UiRestriction;
 public class TabSuggestionMessageCardTest {
     // clang-format on
     private static final String BASE_PARAMS = "force-fieldtrial-params="
-            + "Study.Group:baseline_tab_suggestions/true";
+            + "Study.Group:baseline_tab_suggestions/true/enable_launch_polish/true";
     @Rule
     public ChromeTabbedActivityTestRule mActivityTestRule = new ChromeTabbedActivityTestRule();