Commit 4ca9e163 authored by Zhaoyang Li's avatar Zhaoyang Li Committed by Commit Bot

Revert "[ios] Remove dependency of Showcase on //ios/chrome/app:app_internal"

This reverts commit 95ba7404.

Reason for revert: This change caused  ios_showcase_eg2tests_module failures since https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/2803.

Original change's description:
> [ios] Remove dependency of Showcase on //ios/chrome/app:app_internal
>
> Showcase should not depend on //ios/chrome/app (except for the hooks).
> The dependencies were unnecessary and can be safely removed (after the
> removal of one stale #include).
>
> After this CL, there is no dependency on //ios/chrome/app:app_internal:
>
>   $ gn path out/Debug-iphonesimulator --all \
>       //ios/showcase:ios_showcase_egtests \
>       //ios/chrome/app:app_internal
>   No non-data paths found between these two targets.
>
> Bug: 870935
> Change-Id: I586fe8da7ce2e74dae2cedfd9720044afa97650f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067264
> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: edchin <edchin@chromium.org>
> Reviewed-by: edchin <edchin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#744923}

TBR=sdefresne@chromium.org,edchin@chromium.org

Change-Id: I15a0b32382ac1ff8133b99adb9a317e965a8cf86
Bug: 870935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079148Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745248}
parent bb69759d
......@@ -41,6 +41,7 @@ source_set("eg2_tests") {
":badges_constants",
"//ios/chrome/browser/infobars:badge_public",
"//ios/chrome/browser/ui/badges:public",
"//ios/chrome/test/earl_grey:eg_test_support+eg2",
"//ios/showcase/test:eg2_test",
"//ios/testing/earl_grey:eg_test_support+eg2",
"//ios/third_party/earl_grey2:test_lib",
......@@ -56,6 +57,7 @@ source_set("eg_tests") {
":badges_constants",
"//ios/chrome/browser/infobars:badge",
"//ios/chrome/browser/ui/badges:public",
"//ios/chrome/test/earl_grey:test_support",
"//ios/showcase/test",
"//ios/testing/earl_grey:earl_grey_support",
]
......
......@@ -3,6 +3,7 @@
// found in the LICENSE file.
#import "ios/chrome/browser/ui/badges/badge_constants.h"
#import "ios/chrome/test/earl_grey/chrome_matchers.h"
#import "ios/showcase/badges/sc_badge_constants.h"
#import "ios/showcase/test/showcase_eg_utils.h"
#import "ios/showcase/test/showcase_test_case.h"
......
......@@ -24,6 +24,7 @@ source_set("eg2_tests") {
testonly = true
sources = [ "sc_bubble_egtest.mm" ]
deps = [
"//ios/chrome/test/earl_grey:eg_test_support+eg2",
"//ios/showcase/test:eg2_test",
"//ios/testing/earl_grey:eg_test_support+eg2",
"//ios/third_party/earl_grey2:test_lib",
......@@ -37,6 +38,7 @@ source_set("eg_tests") {
sources = [ "sc_bubble_egtest.mm" ]
deps = [
"//ios/chrome/browser/ui/bubble",
"//ios/chrome/test/earl_grey:test_support",
"//ios/showcase/test",
"//ios/testing/earl_grey:earl_grey_support",
"//ios/third_party/earl_grey:earl_grey+link",
......
......@@ -63,6 +63,7 @@ source_set("eg_tests") {
"//ios/chrome/browser/ui/content_suggestions:content_suggestions_ui",
"//ios/chrome/browser/ui/content_suggestions/cells:cells_ui",
"//ios/chrome/browser/ui/util",
"//ios/chrome/test/earl_grey:test_support",
"//ios/showcase/test",
"//ios/testing/earl_grey:earl_grey_support",
"//ios/third_party/earl_grey:earl_grey+link",
......
......@@ -82,6 +82,7 @@ source_set("eg2_tests") {
testonly = true
sources = [ "showcase_egtest.mm" ]
deps = [
"//ios/chrome/test/earl_grey:eg_test_support+eg2",
"//ios/showcase/test:eg2_test",
"//ios/testing/earl_grey:eg_test_support+eg2",
"//ios/third_party/earl_grey2:test_lib",
......
......@@ -71,6 +71,7 @@ source_set("eg_tests") {
":constants",
"//ios/chrome/browser/ui/infobars/banners:public",
"//ios/chrome/browser/ui/infobars/modals:public",
"//ios/chrome/test/earl_grey:test_support",
"//ios/showcase/infobars",
"//ios/showcase/test",
"//ios/testing/earl_grey:earl_grey_support",
......
......@@ -56,6 +56,7 @@ source_set("eg_test_support+eg2") {
deps = [
"//base",
"//ios/chrome/test/earl_grey:eg_test_support+eg2",
"//ios/third_party/earl_grey2:test_lib",
"//ui/base",
]
......
......@@ -17,6 +17,7 @@ source_set("eg2_tests") {
testonly = true
sources = [ "sc_text_badge_view_egtest.mm" ]
deps = [
"//ios/chrome/test/earl_grey:eg_test_support+eg2",
"//ios/showcase/test:eg2_test",
"//ios/testing/earl_grey:eg_test_support+eg2",
"//ios/third_party/earl_grey2:test_lib",
......@@ -30,6 +31,7 @@ source_set("eg_tests") {
sources = [ "sc_text_badge_view_egtest.mm" ]
deps = [
"//ios/chrome/browser/ui/reading_list:reading_list_ui",
"//ios/chrome/test/earl_grey:test_support",
"//ios/showcase/test",
"//ios/testing/earl_grey:earl_grey_support",
"//ios/third_party/earl_grey:earl_grey+link",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment