Revert "[ios] Remove dependency of Showcase on //ios/chrome/app:app_internal"
This reverts commit 95ba7404. Reason for revert: This change caused ios_showcase_eg2tests_module failures since https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/2803. Original change's description: > [ios] Remove dependency of Showcase on //ios/chrome/app:app_internal > > Showcase should not depend on //ios/chrome/app (except for the hooks). > The dependencies were unnecessary and can be safely removed (after the > removal of one stale #include). > > After this CL, there is no dependency on //ios/chrome/app:app_internal: > > $ gn path out/Debug-iphonesimulator --all \ > //ios/showcase:ios_showcase_egtests \ > //ios/chrome/app:app_internal > No non-data paths found between these two targets. > > Bug: 870935 > Change-Id: I586fe8da7ce2e74dae2cedfd9720044afa97650f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067264 > Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: edchin <edchin@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744923} TBR=sdefresne@chromium.org,edchin@chromium.org Change-Id: I15a0b32382ac1ff8133b99adb9a317e965a8cf86 Bug: 870935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079148Reviewed-by:Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#745248}
Showing
Please register or sign in to comment