Commit 4cbaface authored by Sahir Vellani's avatar Sahir Vellani Committed by Commit Bot

Fix InputHandlerProxyTouchScrollbarTest

This unit test was incorrectly implemented. Fixed by initializing it and
correctly expecting all relevant mocked function calls.

Bug: 1146778
Change-Id: I005c4154dc2d2e53167aa67f56f92a27314f7b19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527632Reviewed-by: default avatarRahul Arakeri <arakeri@microsoft.com>
Reviewed-by: default avatarRobert Flack <flackr@chromium.org>
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#826948}
parent c2d653c9
......@@ -3862,6 +3862,24 @@ TEST_P(InputHandlerProxyTouchScrollbarTest,
cc::InputHandlerPointerResult pointer_down_result;
pointer_down_result.type = cc::PointerResultType::kScrollbarScroll;
pointer_down_result.scroll_offset = gfx::ScrollOffset(0, 1);
cc::InputHandlerPointerResult pointer_up_result;
pointer_up_result.type = cc::PointerResultType::kScrollbarScroll;
EXPECT_CALL(mock_input_handler_,
EventListenerTypeForTouchStartOrMoveAt(
testing::Property(&gfx::Point::x, testing::Eq(10)), _))
.WillOnce(testing::Invoke([](const gfx::Point&,
cc::TouchAction* touch_action) {
*touch_action = cc::TouchAction::kAuto;
return cc::InputHandler::TouchStartOrMoveEventListenerType::NO_HANDLER;
}));
EXPECT_CALL(
mock_input_handler_,
GetEventListenerProperties(cc::EventListenerClass::kTouchStartOrMove))
.WillOnce(testing::Return(cc::EventListenerProperties::kNone));
EXPECT_CALL(mock_client_, SetAllowedTouchAction(_, _, _))
.WillOnce(testing::Return());
EXPECT_CALL(mock_input_handler_, MouseDown(_, _))
.WillOnce(testing::Return(pointer_down_result));
......@@ -3869,11 +3887,21 @@ TEST_P(InputHandlerProxyTouchScrollbarTest,
scroll_result_did_scroll.did_scroll = true;
expected_disposition_ = InputHandlerProxy::DID_HANDLE;
EXPECT_CALL(mock_input_handler_, ScrollingShouldSwitchtoMainThread());
if (!base::FeatureList::IsEnabled(features::kScrollUnification)) {
EXPECT_CALL(mock_input_handler_, ScrollingShouldSwitchtoMainThread())
.WillOnce(testing::Return(false));
}
EXPECT_CALL(
mock_input_handler_,
RecordScrollBegin(ui::ScrollInputType::kScrollbar,
cc::ScrollBeginThreadState::kScrollingOnCompositor))
.Times(1);
EXPECT_CALL(mock_input_handler_, ScrollBegin(_, _))
.WillOnce(testing::Return(kImplThreadScrollState));
EXPECT_CALL(mock_input_handler_, ScrollUpdate(_, _))
.WillRepeatedly(testing::Return(scroll_result_did_scroll));
EXPECT_CALL(mock_input_handler_, MouseUp(_))
.WillOnce(testing::Return(pointer_up_result));
EXPECT_EQ(expected_disposition_,
HandleInputEventAndFlushEventQueue(
......@@ -4225,5 +4253,10 @@ INSTANTIATE_TEST_SUITE_P(All,
kTestCombinations,
kSuffixGenerator);
INSTANTIATE_TEST_SUITE_P(All,
InputHandlerProxyTouchScrollbarTest,
kTestCombinations,
kSuffixGenerator);
} // namespace test
} // namespace blink
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment