Make ScopedTaskEnvironment the first member of QuicHttpProxyBackendStreamTest.
The documentation for ScopedTaskEnvironment recommends making it the first member of the test fixture: https://cs.chromium.org/chromium/src/base/test/scoped_task_environment.h?l=54-59&rcl=376db7a96e0287f0d010acd18e7a379d190cac71 We are chaning this particular case because we want to make the constructor of ScopedTaskEnvironment set a global variable that is read by PlatformThread::SetCurrentThreadPriority(). If ScopedTaskEnvironment is initialized late in the test execution, setting this global variable races with a call to PlatfromThread::SetCurrentThreadPriority() on the thread created from this stack: base::(anonymous namespace)::CreateThread base::PlatformThread::CreateWithPriority base::Thread::StartWithOptions net::test::QuicHttpProxyBackendStreamTest::CreateTestBackendProxy net::test::QuicHttpProxyBackendStreamTest::SetUp Bug: 902441 Change-Id: I4869410f43383bd7f94f68fc7790e3305f3d1b4a Reviewed-on: https://chromium-review.googlesource.com/c/1320654 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#606259}
Showing
Please register or sign in to comment