Commit 4cbd654a authored by ycheo@chromium.org's avatar ycheo@chromium.org

Fix the flaky test, ExternalVideoSurfaceContainerTest#testEnableVideoOverlayForEmbeddedVideo.

The test is 30% failed in Galaxy Nexus, JellyBean at DCHECK(!needs_establish_peer_) of
WebMediaPlayerAndroid::play().
We need to defer the steam texture creation also when we have the switch,
kForceUseOverlayEmbeddedVideo.

BUG=372174

Review URL: https://codereview.chromium.org/281523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269982 0039d316-1c4b-4281-b951-d872f2087c98
parent ceaa5505
...@@ -128,13 +128,14 @@ WebMediaPlayerAndroid::WebMediaPlayerAndroid( ...@@ -128,13 +128,14 @@ WebMediaPlayerAndroid::WebMediaPlayerAndroid(
player_id_ = manager_->RegisterMediaPlayer(this); player_id_ = manager_->RegisterMediaPlayer(this);
#if defined(VIDEO_HOLE) #if defined(VIDEO_HOLE)
if (manager_->ShouldUseVideoOverlayForEmbeddedEncryptedVideo()) { force_use_overlay_embedded_video_ = CommandLine::ForCurrentProcess()->
HasSwitch(switches::kForceUseOverlayEmbeddedVideo);
if (force_use_overlay_embedded_video_ ||
manager_->ShouldUseVideoOverlayForEmbeddedEncryptedVideo()) {
// Defer stream texture creation until we are sure it's necessary. // Defer stream texture creation until we are sure it's necessary.
needs_establish_peer_ = false; needs_establish_peer_ = false;
current_frame_ = VideoFrame::CreateBlackFrame(gfx::Size(1, 1)); current_frame_ = VideoFrame::CreateBlackFrame(gfx::Size(1, 1));
} }
force_use_overlay_embedded_video_ = CommandLine::ForCurrentProcess()->
HasSwitch(switches::kForceUseOverlayEmbeddedVideo);
#endif // defined(VIDEO_HOLE) #endif // defined(VIDEO_HOLE)
TryCreateStreamTextureProxyIfNeeded(); TryCreateStreamTextureProxyIfNeeded();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment