Commit 4d3f2694 authored by Ben Mason's avatar Ben Mason Committed by Commit Bot

Fix TabGridIphTest for release.

Test was passing in debug because of fieldtrial config.
It's not read in release as per: https://source.chromium.org/chromium/chromium/src/+/master:testing/variations/README.md?originalUrl=https:%2F%2Fcs.chromium.org%2F

Enable commandline flag: IPH_TabGroupsDragAndDrop and parameters.

Bug: 1104279
Change-Id: If808af9f027b6c4c294a4d9c7950cbdba01db687
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302833Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: default avatarBen Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790272}
parent b66b2689
...@@ -78,7 +78,18 @@ import java.io.IOException; ...@@ -78,7 +78,18 @@ import java.io.IOException;
/** End-to-end tests for TabGridIph component. */ /** End-to-end tests for TabGridIph component. */
@RunWith(ChromeJUnit4ClassRunner.class) @RunWith(ChromeJUnit4ClassRunner.class)
// clang-format off // clang-format off
@CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE}) @CommandLineFlags.Add({ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE,
"enable-features=IPH_TabGroupsDragAndDrop<TabGroupsDragAndDrop",
"force-fieldtrials=TabGroupsDragAndDrop/Enabled",
"force-fieldtrial-params=TabGroupsDragAndDrop.Enabled:availability/any/" +
"event_trigger/" +
"name%3Aiph_tabgroups_drag_and_drop;comparator%3A==0;window%3A30;storage%3A365/" +
"event_trigger2/" +
"name%3Aiph_tabgroups_drag_and_drop;comparator%3A<2;window%3A90;storage%3A365/" +
"event_used/" +
"name%3Atab_drag_and_drop_to_group;comparator%3A==0;window%3A365;storage%3A365/" +
"session_rate/<1"
})
@Restriction(UiRestriction.RESTRICTION_TYPE_PHONE) @Restriction(UiRestriction.RESTRICTION_TYPE_PHONE)
@Features.EnableFeatures({ChromeFeatureList.TAB_GROUPS_ANDROID}) @Features.EnableFeatures({ChromeFeatureList.TAB_GROUPS_ANDROID})
@Features.DisableFeatures(ChromeFeatureList.CLOSE_TAB_SUGGESTIONS) @Features.DisableFeatures(ChromeFeatureList.CLOSE_TAB_SUGGESTIONS)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment