Commit 4d4bb4b5 authored by Roman Arora's avatar Roman Arora Committed by Commit Bot

Tab Search: Enable feedback button feature flag

Bug: 1099917
Change-Id: I51249a533b84439513708d62e5f56ac83120cce9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427184Reviewed-by: default avatarThomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Roman Arora <romanarora@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810245}
parent d2126dea
...@@ -101,6 +101,10 @@ const base::Feature kTabOutlinesInLowContrastThemes{ ...@@ -101,6 +101,10 @@ const base::Feature kTabOutlinesInLowContrastThemes{
// Enables searching tabs across multiple windows. // Enables searching tabs across multiple windows.
const base::Feature kTabSearch{"TabSearch", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kTabSearch{"TabSearch", base::FEATURE_DISABLED_BY_DEFAULT};
// Enables the tab search submit feedback button.
const base::Feature kTabSearchFeedback{"TabSearchFeedback",
base::FEATURE_DISABLED_BY_DEFAULT};
// Enables the tab search bubble having a fixed tab strip position. // Enables the tab search bubble having a fixed tab strip position.
const base::Feature kTabSearchFixedEntrypoint{ const base::Feature kTabSearchFixedEntrypoint{
"TabSearchFixedEntrypoint", base::FEATURE_DISABLED_BY_DEFAULT}; "TabSearchFixedEntrypoint", base::FEATURE_DISABLED_BY_DEFAULT};
......
...@@ -61,6 +61,8 @@ extern const base::Feature kTabOutlinesInLowContrastThemes; ...@@ -61,6 +61,8 @@ extern const base::Feature kTabOutlinesInLowContrastThemes;
extern const base::Feature kTabSearch; extern const base::Feature kTabSearch;
extern const base::Feature kTabSearchFeedback;
extern const base::Feature kTabSearchFixedEntrypoint; extern const base::Feature kTabSearchFixedEntrypoint;
extern const base::Feature kUseTextForUpdateButton; extern const base::Feature kUseTextForUpdateButton;
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#include "build/branding_buildflags.h" #include "build/branding_buildflags.h"
#include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/ui_features.h"
#include "chrome/browser/ui/webui/favicon_source.h" #include "chrome/browser/ui/webui/favicon_source.h"
#include "chrome/browser/ui/webui/webui_util.h" #include "chrome/browser/ui/webui/webui_util.h"
#include "chrome/common/webui_url_constants.h" #include "chrome/common/webui_url_constants.h"
...@@ -52,6 +53,10 @@ TabSearchUI::TabSearchUI(content::WebUI* web_ui) ...@@ -52,6 +53,10 @@ TabSearchUI::TabSearchUI(content::WebUI* web_ui)
}; };
AddLocalizedStringsBulk(source, kStrings); AddLocalizedStringsBulk(source, kStrings);
source->AddBoolean(
"submitFeedbackEnabled",
base::FeatureList::IsEnabled(features::kTabSearchFeedback));
source->AddLocalizedString("close", IDS_CLOSE); source->AddLocalizedString("close", IDS_CLOSE);
source->AddResourcePath("tab_search.mojom-lite.js", source->AddResourcePath("tab_search.mojom-lite.js",
IDR_TAB_SEARCH_MOJO_LITE_JS); IDR_TAB_SEARCH_MOJO_LITE_JS);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment