Cache cc::SharedBitmaps used by PepperGraphics2DHost to upload

Caching these saves time recreating and remapping them.

Review URL: https://codereview.chromium.org/600953003

Cr-Commit-Position: refs/heads/master@{#296778}

content/renderer/pepper/pepper_graphics_2d_host.cc

@@ -307,6 +307,7 @@ bool PepperGraphics2DHost::BindToInstance(
     new_instance->InvalidateRect(gfx::Rect());
   }
 
+  cached_bitmap_.reset();
   texture_mailbox_modified_ = true;
 
   bound_instance_ = new_instance;
@@ -408,6 +409,10 @@ gfx::Size PepperGraphics2DHost::Size() const {
   return gfx::Size(image_data_->width(), image_data_->height());
 }
 
+void PepperGraphics2DHost::ClearCache() {
+  cached_bitmap_.reset();
+}
+
 int32_t PepperGraphics2DHost::OnHostMsgPaintImageData(
     ppapi::host::HostMessageContext* context,
     const ppapi::HostResource& image_data,
@@ -547,9 +552,17 @@ int32_t PepperGraphics2DHost::OnHostMsgReadImageData(
   return ReadImageData(image, &top_left) ? PP_OK : PP_ERROR_FAILED;
 }
 
-void ReleaseCallback(scoped_ptr<cc::SharedBitmap> bitmap,
-                     uint32 sync_point,
-                     bool lost_resource) {}
+void PepperGraphics2DHost::ReleaseCallback(scoped_ptr<cc::SharedBitmap> bitmap,
+                                           const gfx::Size& bitmap_size,
+                                           uint32 sync_point,
+                                           bool lost_resource) {
+  cached_bitmap_.reset();
+  // Only keep around a cached bitmap if the plugin is currently drawing (has
+  // need_flush_ack_ set).
+  if (need_flush_ack_ && bound_instance_)
+    cached_bitmap_ = bitmap.Pass();
+  cached_bitmap_size_ = bitmap_size;
+}
 
 bool PepperGraphics2DHost::PrepareTextureMailbox(
     cc::TextureMailbox* mailbox,
@@ -558,10 +571,18 @@ bool PepperGraphics2DHost::PrepareTextureMailbox(
     return false;
   // TODO(jbauman): Send image_data_ through mailbox to avoid copy.
   gfx::Size pixel_image_size(image_data_->width(), image_data_->height());
-  scoped_ptr<cc::SharedBitmap> shared_bitmap =
-      RenderThreadImpl::current()
-          ->shared_bitmap_manager()
-          ->AllocateSharedBitmap(pixel_image_size);
+  scoped_ptr<cc::SharedBitmap> shared_bitmap;
+  if (cached_bitmap_) {
+    if (cached_bitmap_size_ == pixel_image_size)
+      shared_bitmap = cached_bitmap_.Pass();
+    else
+      cached_bitmap_.reset();
+  }
+  if (!shared_bitmap) {
+    shared_bitmap = RenderThreadImpl::current()
+                        ->shared_bitmap_manager()
+                        ->AllocateSharedBitmap(pixel_image_size);
+  }
   if (!shared_bitmap)
     return false;
   void* src = image_data_->Map();
@@ -572,7 +593,10 @@ bool PepperGraphics2DHost::PrepareTextureMailbox(
 
   *mailbox = cc::TextureMailbox(shared_bitmap->memory(), pixel_image_size);
   *release_callback = cc::SingleReleaseCallback::Create(
-      base::Bind(&ReleaseCallback, base::Passed(&shared_bitmap)));
+      base::Bind(&PepperGraphics2DHost::ReleaseCallback,
+                 this->AsWeakPtr(),
+                 base::Passed(&shared_bitmap),
+                 pixel_image_size));
   texture_mailbox_modified_ = false;
   return true;
 }

content/renderer/pepper/pepper_graphics_2d_host.h

@@ -20,6 +20,7 @@
 #include "ui/gfx/size.h"
 
 namespace cc {
+class SharedBitmap;
 class SingleReleaseCallback;
 class TextureMailbox;
 }
@@ -85,6 +86,8 @@ class CONTENT_EXPORT PepperGraphics2DHost
   PPB_ImageData_Impl* ImageData();
   gfx::Size Size() const;
 
+  void ClearCache();
+
  private:
   PepperGraphics2DHost(RendererPpapiHost* host,
                        PP_Instance instance,
@@ -157,6 +160,11 @@ class CONTENT_EXPORT PepperGraphics2DHost
                                      gfx::Rect* op_rect,
                                      gfx::Point* delta);
 
+  void ReleaseCallback(scoped_ptr<cc::SharedBitmap> bitmap,
+                       const gfx::Size& bitmap_size,
+                       uint32 sync_point,
+                       bool lost_resource);
+
   RendererPpapiHost* renderer_ppapi_host_;
 
   scoped_refptr<PPB_ImageData_Impl> image_data_;
@@ -193,6 +201,11 @@ class CONTENT_EXPORT PepperGraphics2DHost
   bool texture_mailbox_modified_;
   bool is_using_texture_layer_;
 
+  // This is a bitmap that was recently released by the compositor and may be
+  // used to transfer bytes to the compositor again.
+  scoped_ptr<cc::SharedBitmap> cached_bitmap_;
+  gfx::Size cached_bitmap_size_;
+
   friend class PepperGraphics2DHostTest;
   DISALLOW_COPY_AND_ASSIGN(PepperGraphics2DHost);
 };

content/renderer/pepper/pepper_plugin_instance_impl.cc

@@ -1701,6 +1701,12 @@ void PepperPluginInstanceImpl::SendDidChangeView() {
 
   UpdateLayerTransform();
 
+  if (bound_graphics_2d_platform_ &&
+      (!view_data_.is_page_visible ||
+       PP_ToGfxRect(view_data_.clip_rect).IsEmpty())) {
+    bound_graphics_2d_platform_->ClearCache();
+  }
+
   // It's possible that Delete() has been called but the renderer hasn't
   // released its reference to this object yet.
   if (instance_interface_) {