Commit 4d81744a authored by Jinsuk Kim's avatar Jinsuk Kim Committed by Commit Bot

Instantiate WebContentsAX only when WebContents is ready

The reported crash indicates that WebContents object is null
when WebContentsAccessibility object gets instantiated.
This may happen if AccessibilityNodeProvider is requested
after WebContents/CVC get destroyed. In which case we should
not proceed to creating one but return null instead.

BUG=749761

Change-Id: If74945442fd6d05f2f2090c6e0a6aca375fb04f2
Reviewed-on: https://chromium-review.googlesource.com/590887Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490698}
parent 58042109
......@@ -1930,6 +1930,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
}
mWebContentsAccessibility.enable();
} else if (mNativeAccessibilityAllowed) {
if (mWebContents == null) return null;
mWebContentsAccessibility = WebContentsAccessibility.create(mContext, mContainerView,
mWebContents, mRenderCoordinates, mShouldSetAccessibilityFocusOnPageLoad);
mWebContentsAccessibility.enable();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment