Commit 4d87480d authored by Makoto Shimazu's avatar Makoto Shimazu Committed by Commit Bot

Disable PasswordManagerBrowserTest in browser_tests due to flakiness

Disabled these tests due to random failures:
PasswordManagerBrowserTest.HTMLLoginAfterHTTPAuthIsBlacklisted
PasswordManagerBrowserTest.NoPromptForSeperateLoginFormWhenSwitchingFromHttpsToHttp
PasswordManagerBrowserTest.Redirects
PasswordManagerBrowserTest.SameOriginIframeAutoFillTest

TBR=dvadym@chromium.org

No-Try: true
Bug: 1030579
Change-Id: I03ee08ec048ad85af50908d6d929db61b02793fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949830Reviewed-by: default avatarMakoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721370}
parent 3328e608
......@@ -395,7 +395,8 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest, LoginFailed) {
EXPECT_FALSE(prompt_observer->IsSavePromptShownAutomatically());
}
IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest, Redirects) {
// Disabled due to flakiness: https://crbug.com/1030579.
IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest, DISABLED_Redirects) {
NavigateToFile("/password/password_form.html");
// Fill a form and submit through a <input type="submit"> button. The form
......@@ -1500,9 +1501,11 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
// Tests whether a attempted submission of a malicious credentials gets blocked.
// This simulates a case which is described in http://crbug.com/571580.
//
// Disabled due to flakiness: https://crbug.com/1030579.
IN_PROC_BROWSER_TEST_F(
PasswordManagerBrowserTest,
NoPromptForSeperateLoginFormWhenSwitchingFromHttpsToHttp) {
DISABLED_NoPromptForSeperateLoginFormWhenSwitchingFromHttpsToHttp) {
std::string path = "/password/password_form.html";
GURL https_url(https_test_server().GetURL(path));
ASSERT_TRUE(https_url.SchemeIs(url::kHttpsScheme));
......@@ -2290,8 +2293,10 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
// Check that a password form in an iframe of same origin will not be
// filled in until user interact with the iframe.
//
// Disabled due to flakiness: https://crbug.com/1030579.
IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
SameOriginIframeAutoFillTest) {
DISABLED_SameOriginIframeAutoFillTest) {
// Visit the sign-up form to store a password for autofill later
NavigateToFile("/password/password_form_in_same_origin_iframe.html");
NavigationObserver observer(WebContents());
......@@ -3704,8 +3709,10 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
// TODO(crbug.com/862930) If the inconsistency is fixed, please ensure that the
// code for removing duplicates in password_manager_util.cc is updated and does
// not remove blacklisted credentials which are no longer duplicates.
//
// Disabled due to flakiness: https://crbug.com/1030579.
IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
HTMLLoginAfterHTTPAuthIsBlacklisted) {
DISABLED_HTMLLoginAfterHTTPAuthIsBlacklisted) {
for (bool is_realm_empty : {false, true}) {
scoped_refptr<password_manager::TestPasswordStore> password_store =
static_cast<password_manager::TestPasswordStore*>(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment