Commit 4d900c98 authored by Elly Fong-Jones's avatar Elly Fong-Jones Committed by Commit Bot

mac: disable flaky autofill provider browser tests

Bug: 1076487
Change-Id: I56c86e4097d2309b97ffc614767d53d860d52291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221425
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: default avatarMoe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#773288}
parent 141ddf6a
......@@ -4,6 +4,7 @@
#include "base/base_switches.h"
#include "base/macros.h"
#include "build/build_config.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/url_constants.h"
......@@ -308,26 +309,43 @@ class AutofillProviderBrowserTestWithSkipFlagOff
base::test::ScopedFeatureList feature_list_;
};
#if defined(OS_MACOSX)
// These tests are flaky on Mac: https://crbug.com/1076487
#define MAYBE_InferredLabelChangeImpactFormComparing \
DISABLED_InferredLabelChangeImpactFormComparing
#define MAYBE_InferredLabelChangeNotImpactFormComparing \
DISABLED_InferredLabelChangeNotImpactFormComparing
#define MAYBE_LabelTagChangeImpactFormComparing \
DISABLED_LabelTagChangeImpactFormComparing
#else
#define MAYBE_InferredLabelChangeImpactFormComparing \
InferredLabelChangeImpactFormComparing
#define MAYBE_InferredLabelChangeNotImpactFormComparing \
InferredLabelChangeNotImpactFormComparing
#define MAYBE_LabelTagChangeImpactFormComparing \
LabelTagChangeImpactFormComparing
#endif
IN_PROC_BROWSER_TEST_F(AutofillProviderBrowserTestWithSkipFlagOn,
LabelTagChangeImpactFormComparing) {
MAYBE_LabelTagChangeImpactFormComparing) {
SetLabelChangeExpectationAndTriggerQuery();
ChangeLabelAndCheckResult("label_id", false /*expect_forms_same*/);
}
IN_PROC_BROWSER_TEST_F(AutofillProviderBrowserTestWithSkipFlagOn,
InferredLabelChangeNotImpactFormComparing) {
MAYBE_InferredLabelChangeNotImpactFormComparing) {
SetLabelChangeExpectationAndTriggerQuery();
ChangeLabelAndCheckResult("p_id", true /*expect_forms_same*/);
}
IN_PROC_BROWSER_TEST_F(AutofillProviderBrowserTestWithSkipFlagOff,
LabelTagChangeImpactFormComparing) {
MAYBE_LabelTagChangeImpactFormComparing) {
SetLabelChangeExpectationAndTriggerQuery();
ChangeLabelAndCheckResult("label_id", false /*expect_forms_same*/);
}
IN_PROC_BROWSER_TEST_F(AutofillProviderBrowserTestWithSkipFlagOff,
InferredLabelChangeImpactFormComparing) {
MAYBE_InferredLabelChangeImpactFormComparing) {
SetLabelChangeExpectationAndTriggerQuery();
ChangeLabelAndCheckResult("p_id", false /*expect_forms_same*/);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment