Commit 4dba9504 authored by scherkus@chromium.org's avatar scherkus@chromium.org

Fix memory leaks in BufferedDataSource, BufferedResourceLoader and SimpleDataSource unit tests.

BUG=65664
TEST=test_shell_tests + valgrind/heapcheck

Review URL: http://codereview.chromium.org/6246017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72316 0039d316-1c4b-4281-b951-d872f2087c98
parent b84d62f9
...@@ -1072,30 +1072,6 @@ ...@@ -1072,30 +1072,6 @@
fun:testing::HandleExceptionsInMethodIfSupported fun:testing::HandleExceptionsInMethodIfSupported
fun:testing::Test::Run fun:testing::Test::Run
} }
{
bug_65664a
Heapcheck:Leak
fun:webkit_glue::BufferedResourceLoaderTest::Initialize
fun:webkit_glue::BufferedResourceLoaderTest*
}
{
bug_65664b
Heapcheck:Leak
fun:webkit_glue::BufferedDataSourceTest::InitializeDataSource
fun:webkit_glue::BufferedDataSourceTest*
}
{
bug_65664c
Heapcheck:Leak
fun:webkit_glue::SimpleDataSourceTest::InitializeDataSource
fun:webkit_glue::SimpleDataSourceTest*
}
{
bug_65664d
Heapcheck:Leak
fun:webkit_glue::SimpleDataSourceTest_InitializeData_Test::TestBody
fun:testing::HandleExceptionsInMethodIfSupported
}
{ {
bug_65680a bug_65680a
Heapcheck:Leak Heapcheck:Leak
......
...@@ -3370,34 +3370,6 @@ ...@@ -3370,34 +3370,6 @@
fun:*ThemeMapENS_25DefaultLazyInstanceTraitsIS2_EEE3GetEv fun:*ThemeMapENS_25DefaultLazyInstanceTraitsIS2_EEE3GetEv
fun:_ZN13ResourcesUtil18GetThemeResourceIdERKSs fun:_ZN13ResourcesUtil18GetThemeResourceIdERKSs
} }
{
bug_65664a
Memcheck:Leak
fun:_Znw*
fun:_ZN11webkit_glue26BufferedResourceLoaderTest10InitializeEPKcii
fun:_ZN11webkit_glue*BufferedResourceLoaderTest*
}
{
bug_65664b
Memcheck:Leak
fun:_Znw*
fun:_ZN11webkit_glue22BufferedDataSourceTest20InitializeDataSource*
fun:_ZN11webkit_glue*BufferedDataSourceTest*
}
{
bug_65664c
Memcheck:Leak
fun:_Znw*
fun:_ZN11webkit_glue20SimpleDataSourceTest20InitializeDataSourceEPKcPN5media12MockCallbackE
fun:_ZN11webkit_glue*SimpleDataSourceTest*
}
{
bug_65664d
Memcheck:Leak
fun:_Znw*
fun:_ZN11webkit_glue40SimpleDataSourceTest_InitializeData_Test8TestBodyEv
fun:_ZN7testing*HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS3_FS2_vEPKc
}
{ {
bug_65680a bug_65680a
Memcheck:Leak Memcheck:Leak
...@@ -3653,4 +3625,3 @@ ...@@ -3653,4 +3625,3 @@
fun:_ZN9talk_base12MessageQueue8DispatchEPNS_7MessageE fun:_ZN9talk_base12MessageQueue8DispatchEPNS_7MessageE
fun:_ZN9talk_base6Thread15ProcessMessagesEi fun:_ZN9talk_base6Thread15ProcessMessagesEi
} }
\ No newline at end of file
...@@ -105,7 +105,6 @@ class BufferedDataSourceTest : public testing::Test { ...@@ -105,7 +105,6 @@ class BufferedDataSourceTest : public testing::Test {
} }
virtual ~BufferedDataSourceTest() { virtual ~BufferedDataSourceTest() {
ignore_result(frame_.release());
} }
void ExpectCreateAndStartResourceLoader(int start_error) { void ExpectCreateAndStartResourceLoader(int start_error) {
......
...@@ -74,7 +74,6 @@ class BufferedResourceLoaderTest : public testing::Test { ...@@ -74,7 +74,6 @@ class BufferedResourceLoaderTest : public testing::Test {
} }
virtual ~BufferedResourceLoaderTest() { virtual ~BufferedResourceLoaderTest() {
ignore_result(frame_.release());
} }
void Initialize(const char* url, int first_position, int last_position) { void Initialize(const char* url, int first_position, int last_position) {
...@@ -483,4 +482,3 @@ TEST_F(BufferedResourceLoaderTest, AllowDefer_DeferredReadPastWindow) { ...@@ -483,4 +482,3 @@ TEST_F(BufferedResourceLoaderTest, AllowDefer_DeferredReadPastWindow) {
// TODO(hclam): add unit test for defer loading. // TODO(hclam): add unit test for defer loading.
} // namespace webkit_glue } // namespace webkit_glue
...@@ -56,7 +56,6 @@ class SimpleDataSourceTest : public testing::Test { ...@@ -56,7 +56,6 @@ class SimpleDataSourceTest : public testing::Test {
} }
virtual ~SimpleDataSourceTest() { virtual ~SimpleDataSourceTest() {
ignore_result(frame_.release());
} }
void InitializeDataSource(const char* url, void InitializeDataSource(const char* url,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment