Settings: Migrate help page browsertest to Polymer 3

Bug: 1026426
Change-Id: I283187f2b4797e2ce88fe7b68c23795971e7cba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148481
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759093}

chrome/test/data/webui/settings/cr_settings_v3_browsertest.js

@@ -430,6 +430,7 @@ TEST_F('CrSettingsAdvancedPageV3Test', 'MAYBE_Load', function() {
  ['DownloadsPage', 'downloads_page_test.m.js'],
  ['DropdownMenu', 'dropdown_menu_tests.m.js'],
  ['ExtensionControlledIndicator', 'extension_controlled_indicator_tests.m.js'],
+ ['HelpPage', 'help_page_v3_test.js'],
  ['Languages', 'languages_tests.m.js'],
  ['Menu', 'settings_menu_test.m.js'],
  ['OnStartupPage', 'on_startup_page_tests.m.js'],

chrome/test/data/webui/settings/help_page_browsertest.js

-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/** @fileoverview Material Help page tests. */
-
-// Polymer BrowserTest fixture.
-GEN_INCLUDE(['//chrome/test/data/webui/polymer_browser_test_base.js']);
-
-GEN('#include "chrome/browser/ui/ui_features.h"');
-
-/**
- * @constructor
- * @extends {PolymerTest}
- */
-function SettingsHelpPageBrowserTest() {}
-
-SettingsHelpPageBrowserTest.prototype = {
-  __proto__: PolymerTest.prototype,
-
-  /** @override */
-  browsePreload: 'chrome://help/',
-
-  /** @override */
-  featureList: {disabled: ['features::kSettingsPolymer3']},
-
-  /** @override */
-  extraLibraries: [
-    ...PolymerTest.prototype.extraLibraries,
-    'settings_page_test_util.js',
-  ],
-
-  /** @override */
-  setUp: function() {
-    // Intentionally bypassing SettingsPageBrowserTest#setUp.
-    PolymerTest.prototype.setUp.call(this);
-  },
-};
-
-TEST_F('SettingsHelpPageBrowserTest', 'Load', function() {
-  // Register mocha tests.
-  suite('Help page', function() {
-    test('about section', function() {
-      return settings_page_test_util.getPage('about').then(function(page) {
-        expectTrue(!!settings_page_test_util.getSection(page, 'about'));
-      });
-    });
-  });
-
-  // Run all registered tests.
-  mocha.run();
-});

chrome/test/data/webui/settings/help_page_v3_test.js

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/** @fileoverview Suite of tests for the Settings help page. */
+
+// clang-format off
+import 'chrome://settings/settings.js';
+import {getPage, getSection} from 'chrome://test/settings/settings_page_test_util.m.js';
+import {waitBeforeNextRender} from 'chrome://test/test_util.m.js';
+// clang-format on
+
+// Register mocha tests.
+suite('SettingsHelpPage', function() {
+  setup(function() {
+    PolymerTest.clearBody();
+    // The ChromeContentBrowserClient will rewrite chrome://help to
+    // chrome://settings/help.
+    window.history.pushState('', 'Test', 'chrome://settings/help');
+    const settingsUi = document.createElement('settings-ui');
+    document.body.appendChild(settingsUi);
+
+    // Wait for the dom-if.
+    return waitBeforeNextRender(settingsUi);
+  });
+
+  test('about section', async () => {
+    const page = await getPage('about');
+    expectTrue(!!getSection(page, 'about'));
+  });
+});